Skip to content

Commit

Permalink
base: Expand comment on how to keep owners file synced with lsc-owner…
Browse files Browse the repository at this point in the history
…s-override

Change-Id: I611f902e37a37e7cc362569a08e75d1c02c99299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276975
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#943069}
  • Loading branch information
nico authored and Chromium LUCI CQ committed Nov 18, 2021
1 parent fddcc50 commit dc535d6
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ENG_REVIEW_OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# addings of top-level and third-party directories.

# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.
creis@chromium.org
estaab@chromium.org
haraken@chromium.org
Expand All @@ -10,3 +11,4 @@ pinkerton@chromium.org
sky@chromium.org
yfriedman@chromium.org
# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.
2 changes: 2 additions & 0 deletions base/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

set noparent
# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.
ajwong@chromium.org
danakj@chromium.org
dcheng@chromium.org
Expand All @@ -14,6 +15,7 @@ thakis@chromium.org
thestig@chromium.org
wez@chromium.org
# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.

# per-file rules:
# These are for the common case of adding or renaming files. If you're doing
Expand Down
2 changes: 2 additions & 0 deletions build/OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
set noparent
# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.
agrieve@chromium.org
brucedawson@chromium.org
dpranke@google.com
Expand All @@ -16,6 +17,7 @@ file://tools/clang/scripts/OWNERS
wnwen@chromium.org

# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.

per-file .gitignore=*
per-file check_gn_headers_whitelist.txt=*
Expand Down
2 changes: 2 additions & 0 deletions content/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

set noparent
# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.
alexmos@chromium.org
altimin@chromium.org
arthursonzogni@chromium.org
Expand All @@ -27,6 +28,7 @@ kinuko@chromium.org
nasko@chromium.org
pfeldman@chromium.org
# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.

# per-file rules:

Expand Down
2 changes: 2 additions & 0 deletions third_party/blink/public/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.
chrishtr@chromium.org
danakj@chromium.org
dcheng@chromium.org
Expand All @@ -15,6 +16,7 @@ pdr@chromium.org
pfeldman@chromium.org
tkent@chromium.org
# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.

# This is for the common case of adding or renaming files. If you're doing
# structural changes, please get a review from a reviewer in this file.
Expand Down
2 changes: 2 additions & 0 deletions url/OWNERS
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
set noparent
# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.
csharrison@chromium.org
dcheng@chromium.org
mkwst@chromium.org
timothygu@chromium.org
# NOTE: keep this in sync with lsc-owners-override@chromium.org owners
# by emailing lsc-policy@chromium.org when this list changes.

0 comments on commit dc535d6

Please sign in to comment.