[Background Fetch] Remove deprecated proto field.

The field was deprecated in M71, and is no longer needed Change-Id: I258b64134cbd95fd99d1a57d43c94d204bd46251 Reviewed-on: https://chromium-review.googlesource.com/c/1426684 Reviewed-by: Mugdha Lakhani <nator@google.com> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#624908}
Denger-Network · Jan 22, 2019 · dcdbdf5 · dcdbdf5
1 parent b270239
commit dcdbdf5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/content/browser/background_fetch/background_fetch.proto b/content/browser/background_fetch/background_fetch.proto
@@ -167,7 +167,8 @@ message BackgroundFetchCompletedRequest {
   optional int32 request_index = 2;
   optional string serialized_request = 3;
   optional string download_guid = 4;
-  optional bool succeeded = 5 [deprecated = true];
   optional BackgroundFetchRegistration.BackgroundFetchFailureReason
       failure_reason = 6;
+
+  reserved 5;
 }
diff --git a/content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc b/content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc
@@ -129,17 +129,6 @@ void MarkRegistrationForDeletionTask::DidGetCompletedRequests(
       return;
     }
 
-    // TODO(rayankans): Delete this after M71 is out of use.
-    // |succeeded| was deprecated in favor of |failure_reason|.
-    // This can happen if a browser was updated while a fetch was ongoing.
-    if (completed_request.has_succeeded()) {
-      if (!completed_request.succeeded()) {
-        // The fetch failed, expose the error as FETCH_ERROR.
-        failure_reason_ =
-            blink::mojom::BackgroundFetchFailureReason::FETCH_ERROR;
-      }
-    }
-
     if (completed_request.failure_reason() !=
         proto::BackgroundFetchRegistration::NONE) {
       bool did_convert = MojoFailureReasonFromRegistrationProto(