Skip to content

Commit

Permalink
Improve a11y stops on Diagnostics data-point element
Browse files Browse the repository at this point in the history
This change removes an empty stop in the data-point component

Bug: 1125150
Change-Id: Iaf0c606a99629bb3fe43fd903f9a23356eaf366c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2688026
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#853177}
  • Loading branch information
abaileyb authored and Chromium LUCI CQ committed Feb 11, 2021
1 parent 294210c commit ddcd2d6
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions chromeos/components/diagnostics_ui/resources/data_point.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#infoIcon {
bottom: 1px;
fill: var(--google-grey-700);
fill: var(--google-grey-700);
height: 20px;
left: 4px;
width: 20px;
Expand All @@ -31,11 +31,15 @@
</style>
<div class="data-point">
<div class="header">
<span>[[header]]</span>
<span id="headerText" aria-hidden="true"> [[header]]</span>
<iron-icon slot="icon" icon="cr:info-outline" id="infoIcon"
hidden$="[[!tooltipText]]">
hidden$="[[!tooltipText]]">
</iron-icon>
<paper-tooltip for="infoIcon">[[tooltipText]]</paper-tooltip>
<paper-tooltip for="infoIcon" aria-hidden="true">
<span id="tooltipText">[[tooltipText]]</span>
</paper-tooltip>
</div>
<div class$="[[getValueClass_(warningState)]]">[[value]]</div>
</div>
<div class$="[[getValueClass_(warningState)]]" aria-labelledby="headerText"
aria-describedby="tooltipText"> [[value]]
</div>
</div>

0 comments on commit ddcd2d6

Please sign in to comment.