Skip to content

Commit

Permalink
Remove the kDisableNewVirtualKeyboardBehavior flag definition.
Browse files Browse the repository at this point in the history
The last references to this flag were removed in:
crrev.com/c/686027

There is notably still a reference to the
disable-new-virtual-keyboard-behavior flag in
tools/metrics/histograms/enums.xml which should not be removed.


Bug: 755460
Change-Id: I5d63f5fdde1884527baded293110c681d8869371
Reviewed-on: https://chromium-review.googlesource.com/718156
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508976}
  • Loading branch information
Blake O'Hare authored and Commit Bot committed Oct 16, 2017
1 parent a5661f5 commit e030df0
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 19 deletions.
4 changes: 0 additions & 4 deletions chrome/browser/about_flags.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3240,10 +3240,6 @@ const FeatureEntry kFeatureEntries[] = {
#endif // defined(OS_MACOSX)

#if defined(OS_CHROMEOS)
{"disable-new-virtual-keyboard-behavior",
flag_descriptions::kDisableNewVirtualKeyboardBehaviorName,
flag_descriptions::kDisableNewVirtualKeyboardBehaviorDescription, kOsCrOS,
SINGLE_DISABLE_VALUE_TYPE(switches::kDisableNewVirtualKeyboardBehavior)},
{"enable-per-user-timezone", flag_descriptions::kEnablePerUserTimezoneName,
flag_descriptions::kEnablePerUserTimezoneDescription, kOsCrOS,
SINGLE_DISABLE_VALUE_TYPE(chromeos::switches::kDisablePerUserTimezone)},
Expand Down
6 changes: 0 additions & 6 deletions chrome/browser/flag_descriptions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2344,12 +2344,6 @@ const char kDisableLockScreenAppsDescription[] =
"not be able to launch the preferred note-taking action from the lock "
"screen, provided that the app supports lock screen note taking.";

const char kDisableNewVirtualKeyboardBehaviorName[] =
"New window behavior for the accessibility keyboard";
const char kDisableNewVirtualKeyboardBehaviorDescription[] =
"Disable new window behavior for the accessibility keyboard in non-sticky "
"mode (do not change work area in non-sticky mode).";

const char kDisableTabletAutohideTitlebarsName[] =
"Disable autohide titlebars in tablet mode";
const char kDisableTabletAutohideTitlebarsDescription[] =
Expand Down
3 changes: 0 additions & 3 deletions chrome/browser/flag_descriptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -1444,9 +1444,6 @@ extern const char kCrosRegionsModeHide[];
extern const char kDisableLockScreenAppsName[];
extern const char kDisableLockScreenAppsDescription[];

extern const char kDisableNewVirtualKeyboardBehaviorName[];
extern const char kDisableNewVirtualKeyboardBehaviorDescription[];

extern const char kDisableTabletAutohideTitlebarsName[];
extern const char kDisableTabletAutohideTitlebarsDescription[];

Expand Down
5 changes: 0 additions & 5 deletions ui/base/ui_base_switches.cc
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,6 @@ const char kTopChromeMDMaterialHybrid[] = "material-hybrid";
// Classic, non-material, mode for the |kTopChromeMD| switch.
const char kTopChromeMDNonMaterial[] = "non-material";

// Disable new window behavior for virtual keyboard (do not change work area in
// non-sticky mode).
const char kDisableNewVirtualKeyboardBehavior[] =
"disable-new-virtual-keyboard-behavior";

// Applies the material design mode passed via --top-chrome-md to elements
// throughout Chrome (not just top Chrome).
const char kExtendMdToSecondaryUi[] = "secondary-ui-md";
Expand Down
1 change: 0 additions & 1 deletion ui/base/ui_base_switches.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ UI_BASE_EXPORT extern const char kEnableMergeKeyCharEvents[];

UI_BASE_EXPORT extern const char kDisableCompositedAntialiasing[];
UI_BASE_EXPORT extern const char kDisableDwmComposition[];
UI_BASE_EXPORT extern const char kDisableNewVirtualKeyboardBehavior[];
UI_BASE_EXPORT extern const char kDisableTouchAdjustment[];
UI_BASE_EXPORT extern const char kDisableTouchDragDrop[];
UI_BASE_EXPORT extern const char kEnableTouchDragDrop[];
Expand Down

0 comments on commit e030df0

Please sign in to comment.