Skip to content

Commit

Permalink
Enable password change browsertest
Browse files Browse the repository at this point in the history
Password change browsertest was failing before when HTML Imports API is
disabled.But now the HTML Imports are removed and browsertest should be
working fine.

Bug: 1022192
Change-Id: Ie004df3804f364bc40846b745abc189fb78d24ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2745556
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861522}
  • Loading branch information
Mohammed Abdon authored and Chromium LUCI CQ committed Mar 10, 2021
1 parent bc7fe33 commit e4ba2c3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -196,29 +196,23 @@ class PasswordChangeExtensionTest : public extensions::ExtensionBrowserTest {
std::unique_ptr<InSessionPasswordChangeManager> password_change_manager_;
};

// TODO(crbug.com/1022192) This test fails when HTML Imports is disabled.
IN_PROC_BROWSER_TEST_F(PasswordChangeExtensionTest,
DISABLED_DetectAdfsSuccess) {
IN_PROC_BROWSER_TEST_F(PasswordChangeExtensionTest, DetectAdfsSuccess) {
fake_idp_.SetFormSubmitAction("/adfs/portal/updatepassword/");
fake_idp_.RedirectNextPostTo("/adfs/portal/updatepassword/?status=0");

InSessionPasswordChangeManager::Get()->StartInSessionPasswordChange();
WaitForPasswordChangeDetected();
}

// TODO(crbug.com/1022192) This test fails when HTML Imports is disabled.
IN_PROC_BROWSER_TEST_F(PasswordChangeExtensionTest,
DISABLED_DetectAzureSuccess) {
IN_PROC_BROWSER_TEST_F(PasswordChangeExtensionTest, DetectAzureSuccess) {
fake_idp_.SetFormSubmitAction("/ChangePassword.aspx");
fake_idp_.RedirectNextPostTo("/ChangePassword.aspx?ReturnCode=0");

InSessionPasswordChangeManager::Get()->StartInSessionPasswordChange();
WaitForPasswordChangeDetected();
}

// TODO(crbug.com/1022192) This test fails when HTML Imports is disabled.
IN_PROC_BROWSER_TEST_F(PasswordChangeExtensionTest,
DISABLED_DetectPingSuccess) {
IN_PROC_BROWSER_TEST_F(PasswordChangeExtensionTest, DetectPingSuccess) {
fake_idp_.SetFormSubmitAction(
"/idp/directory/a/12345/password/chg/67890?returnurl=/Selection");
fake_idp_.RedirectNextPostTo("/Selection");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,29 +182,23 @@ class PasswordChangeSuccessDetectionTest
std::unique_ptr<InSessionPasswordChangeManager> password_change_manager_;
};

// TODO(crbug.com/1022192) This test fails when HTML Imports is disabled.
IN_PROC_BROWSER_TEST_F(PasswordChangeSuccessDetectionTest,
DISABLED_DetectAdfsSuccess) {
IN_PROC_BROWSER_TEST_F(PasswordChangeSuccessDetectionTest, DetectAdfsSuccess) {
fake_idp_.SetFormSubmitAction("/adfs/portal/updatepassword/");
fake_idp_.RedirectNextPostTo("/adfs/portal/updatepassword/?status=0");

InSessionPasswordChangeManager::Get()->StartInSessionPasswordChange();
WaitForPasswordChangeDetected();
}

// TODO(crbug.com/1022192) This test fails when HTML Imports is disabled.
IN_PROC_BROWSER_TEST_F(PasswordChangeSuccessDetectionTest,
DISABLED_DetectAzureSuccess) {
IN_PROC_BROWSER_TEST_F(PasswordChangeSuccessDetectionTest, DetectAzureSuccess) {
fake_idp_.SetFormSubmitAction("/ChangePassword.aspx");
fake_idp_.RedirectNextPostTo("/ChangePassword.aspx?ReturnCode=0");

InSessionPasswordChangeManager::Get()->StartInSessionPasswordChange();
WaitForPasswordChangeDetected();
}

// TODO(crbug.com/1022192) This test fails when HTML Imports is disabled.
IN_PROC_BROWSER_TEST_F(PasswordChangeSuccessDetectionTest,
DISABLED_DetectPingSuccess) {
IN_PROC_BROWSER_TEST_F(PasswordChangeSuccessDetectionTest, DetectPingSuccess) {
fake_idp_.SetFormSubmitAction(
"/idp/directory/a/12345/password/chg/67890?returnurl=/Selection");
fake_idp_.RedirectNextPostTo("/Selection");
Expand Down

0 comments on commit e4ba2c3

Please sign in to comment.