forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix timeout failure for wpt select-event.html
WPT select-event.html test needs to wait for rendering in an interopability manner before doing select event assertions. The previous implementation of using 2 requestAnimationFrame() causes Firefox test to be flaky as there wasn't a guarantee that the rendering will be done before by then [1]. However, using setTimeout(resolve, 0) breaks chrome as it doesn't guarantee two frames are processed as chrome schedules through the next animation frame. By having both, we should fix this flakiness for all browsers. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1785615 Fixed: 1420110 Change-Id: Iaeaffbb04786b94b11daa3ed816d8679e0593d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296974 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1112425}
- Loading branch information
1 parent
4b999d2
commit e5f2b87
Showing
5 changed files
with
12 additions
and
836 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.