Skip to content

Commit

Permalink
media: disable RecordSingleVisitOnSameOrigin on Mac
Browse files Browse the repository at this point in the history
This test is already disabled as flaky on Windows & Linux; it appears to flakily
time out on Mac (quite often actually) as well.

Bug: 1014229, 1028239
Change-Id: I278543f670e5723ecb0428d09863367bbf8c772e
Tbr: thestig@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946824
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720562}
  • Loading branch information
Elly Fong-Jones authored and Commit Bot committed Dec 2, 2019
1 parent f0e8e47 commit e6b9a51
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chrome/browser/media/media_engagement_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, RecordVisitOnBrowserClose) {
ExpectScores(1, 0, 1, 0);
}

#if defined(OS_WIN) || defined(OS_LINUX)
#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_MACOSX)
// Flaky timeout. https://crbug.com/1014229
#define MAYBE_RecordSingleVisitOnSameOrigin \
DISABLED_RecordSingleVisitOnSameOrigin
Expand Down

0 comments on commit e6b9a51

Please sign in to comment.