Prevent sign extension for pointer trace values

This makes 32-bit pointers serialize like "0xdeadbeef", not "0xffffffffdeadbeef". BUG=618221 Review-Url: https://codereview.chromium.org/2043233003 Cr-Commit-Position: refs/heads/master@{#399347}
Denger-Network · Jun 11, 2016 · e853dea · e853dea
1 parent a1e9d87
commit e853dea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/base/trace_event/trace_event_impl.cc b/base/trace_event/trace_event_impl.cc
@@ -261,7 +261,7 @@ void TraceEvent::AppendValueAsJSON(unsigned char type,
       // So as not to lose bits from a 64-bit pointer, output as a hex string.
       StringAppendF(
           out, "\"0x%" PRIx64 "\"",
-          static_cast<uint64_t>(reinterpret_cast<intptr_t>(value.as_pointer)));
+          static_cast<uint64_t>(reinterpret_cast<uintptr_t>(value.as_pointer)));
       break;
     case TRACE_VALUE_TYPE_STRING:
     case TRACE_VALUE_TYPE_COPY_STRING:

diff --git a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
@@ -41,7 +41,7 @@ namespace blink {
 
 String toHexString(const void* p)
 {
-    return String::format("0x%" PRIx64, static_cast<uint64_t>(reinterpret_cast<intptr_t>(p)));
+    return String::format("0x%" PRIx64, static_cast<uint64_t>(reinterpret_cast<uintptr_t>(p)));
 }
 
 void setCallStack(TracedValue* value)