Skip to content

Commit

Permalink
Rollback ContextMenu
Browse files Browse the repository at this point in the history 
This CL aims to drop the context menu feature entirely.
<menuitem> tag can be no longer used and <menu type='context'>, <menu label='...'> are no longer supported.

BUG=87553

Review-Url: https://codereview.chromium.org/2905763003
Cr-Commit-Position: refs/heads/master@{#476230}
  • Loading branch information
yuzus authored and Commit Bot committed Jun 1, 2017
1 parent 4a04880 commit e90a048
Show file tree
Hide file tree
Showing 68 changed files with 364 additions and 1,933 deletions.
9 changes: 0 additions & 9 deletions third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9387,7 +9387,6 @@ crbug.com/591099 fast/dom/HTMLElement/bdo.html [ Failure ]
crbug.com/591099 fast/dom/HTMLElement/class-list-gc.html [ Failure ]
crbug.com/591099 fast/dom/HTMLElement/class-list.html [ Failure ]
crbug.com/591099 fast/dom/HTMLElement/class-list-quirks.html [ Failure ]
crbug.com/591099 fast/dom/HTMLElement/contextmenu.html [ Failure ]
crbug.com/591099 fast/dom/HTMLElement/innerHTML-selection-crash.html [ Crash Failure ]
crbug.com/591099 fast/dom/HTMLElement/insertAdjacentHTML-errors.html [ Failure ]
crbug.com/591099 fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html [ Failure ]
Expand Down Expand Up @@ -10341,7 +10340,6 @@ crbug.com/591099 fast/events/constructors/page-transition-event-constructor.html
crbug.com/591099 fast/events/constructors/pointer-event-constructor.html [ Failure Timeout ]
crbug.com/591099 fast/events/constructors/pop-state-event-constructor.html [ Failure ]
crbug.com/591099 fast/events/constructors/progress-event-constructor.html [ Failure ]
crbug.com/591099 fast/events/constructors/related-event-constructor.html [ Failure ]
crbug.com/591099 fast/events/constructors/security-policy-violation-event-constructor.html [ Failure ]
crbug.com/591099 fast/events/constructors/speech-recognition-error-constructor.html [ Failure ]
crbug.com/591099 fast/events/constructors/speech-recognition-event-constructor.html [ Failure ]
Expand Down Expand Up @@ -10685,7 +10683,6 @@ crbug.com/591099 fast/events/popup-forwarded-gesture-blocked.html [ Failure ]
crbug.com/591099 fast/events/popup-forwarded-gesture.html [ Failure ]
crbug.com/591099 fast/events/programmatic-check-no-change-event.html [ Failure ]
crbug.com/591099 fast/events/recorded-keydown-event.html [ Crash ]
crbug.com/591099 fast/events/relatedevent.html [ Failure ]
crbug.com/591099 fast/events/related-target-focusevent.html [ Failure Timeout ]
crbug.com/591099 fast/events/related-target.html [ Failure ]
crbug.com/591099 fast/events/relative-offset-of-simulated-click.html [ Failure ]
Expand Down Expand Up @@ -13697,7 +13694,6 @@ crbug.com/591099 fast/parser/noscript-with-javascript-disabled.html [ Failure ]
crbug.com/591099 fast/parser/object-with-textarea-fallback.html [ Crash ]
crbug.com/591099 fast/parser/open-comment-in-style.html [ Failure ]
crbug.com/591099 fast/parser/open-comment-in-textarea.html [ Crash Failure ]
crbug.com/591099 fast/parser/parse-menuitem.html [ Failure ]
crbug.com/591099 fast/parser/parse-wbr.html [ Failure ]
crbug.com/591099 fast/parser/p-in-scope.html [ Failure ]
crbug.com/591099 fast/parser/p-in-scope-strict.html [ Failure ]
Expand Down Expand Up @@ -15492,9 +15488,6 @@ crbug.com/591099 html/grouping_content/listing.html [ Failure ]
crbug.com/591099 html/grouping_content/main-element.html [ Failure ]
crbug.com/591099 html/marquee/marquee-element.html [ Failure ]
crbug.com/591099 html/marquee/marquee-shadow-root-no-access.html [ Crash ]
crbug.com/591099 html/menu_menuitem/custom-context-menu.html [ Failure ]
crbug.com/591099 html/menu_menuitem/menuitem-click.html [ Failure ]
crbug.com/591099 html/menu_menuitem/menu-type-context.html [ Failure Pass ]
crbug.com/591099 html/sections/article-element.html [ Failure ]
crbug.com/591099 html/sections/aside-element.html [ Failure ]
crbug.com/591099 html/sections/body-quirk-client-size.html [ Failure ]
Expand Down Expand Up @@ -16205,7 +16198,6 @@ crbug.com/591099 http/tests/misc/client-hints-preload-rw-sizes.html [ Crash ]
crbug.com/591099 http/tests/misc/copy-resolves-urls.html [ Failure ]
crbug.com/591099 http/tests/misc/crash-multiple-family-fontface.html [ Failure ]
crbug.com/591099 http/tests/misc/css-reject-any-type-in-strict-mode.html [ Failure ]
crbug.com/591099 http/tests/misc/custom-context-menu.html [ Failure ]
crbug.com/591099 http/tests/misc/delete-frame-during-readystatechange.html [ Crash ]
crbug.com/591099 http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html [ Crash ]
crbug.com/591099 http/tests/misc/detach-during-notifyDone.html [ Crash ]
Expand Down Expand Up @@ -23583,7 +23575,6 @@ crbug.com/591099 virtual/off-main-thread-fetch/http/tests/misc/client-hints-prel
crbug.com/591099 virtual/off-main-thread-fetch/http/tests/misc/copy-resolves-urls.html [ Crash Failure ]
crbug.com/591099 virtual/off-main-thread-fetch/http/tests/misc/crash-multiple-family-fontface.html [ Failure ]
crbug.com/591099 virtual/off-main-thread-fetch/http/tests/misc/css-reject-any-type-in-strict-mode.html [ Failure ]
crbug.com/591099 virtual/off-main-thread-fetch/http/tests/misc/custom-context-menu.html [ Failure ]
crbug.com/591099 virtual/off-main-thread-fetch/http/tests/misc/delete-frame-during-readystatechange.html [ Crash ]
crbug.com/591099 virtual/off-main-thread-fetch/http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html [ Crash ]
crbug.com/591099 virtual/off-main-thread-fetch/http/tests/misc/detach-during-notifyDone.html [ Crash ]
Expand Down
4 changes: 2 additions & 2 deletions ..._party/WebKit/LayoutTests/external/wpt/custom-elements/reactions/HTMLElement-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ PASS draggable on HTMLElement must enqueue an attributeChanged reaction when add
PASS draggable on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
FAIL dropzone on HTMLElement must enqueue an attributeChanged reaction when adding dropzone content attribute assert_array_equals: lengths differ, expected 1 got 0
FAIL dropzone on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
FAIL contextMenu on HTMLElement must enqueue an attributeChanged reaction when adding contextmenu content attribute Failed to set the 'contextMenu' property on 'HTMLElement': The provided value is not of type 'HTMLMenuElement'.
FAIL contextMenu on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute Failed to set the 'contextMenu' property on 'HTMLElement': The provided value is not of type 'HTMLMenuElement'.
FAIL contextMenu on HTMLElement must enqueue an attributeChanged reaction when adding contextmenu content attribute assert_array_equals: lengths differ, expected 1 got 0
FAIL contextMenu on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute assert_array_equals: lengths differ, expected 2 got 1
PASS spellcheck on HTMLElement must enqueue an attributeChanged reaction when adding spellcheck content attribute
PASS spellcheck on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
PASS innerText on HTMLElement must enqueue a disconnected reaction
Expand Down
Loading

0 comments on commit e90a048

Please sign in to comment.