ui/base/clipboard: Use default constructors

Ref: https://abseil.io/tips/131 https: //stackoverflow.com/questions/20828907/the-new-keyword-default-in-c11?lq=1 Change-Id: I10dffd5bd13d6f619e4f758ec154947bbef86d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607185 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659299}
Denger-Network · May 14, 2019 · eaaaa0a · eaaaa0a
1 parent 152e647
commit eaaaa0a
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 13 deletions.
diff --git a/ui/base/clipboard/clipboard.h b/ui/base/clipboard/clipboard.h
@@ -146,8 +146,8 @@ class COMPONENT_EXPORT(BASE_CLIPBOARD) Clipboard : public base::ThreadChecker {
  protected:
   static Clipboard* Create();
 
-  Clipboard() {}
-  virtual ~Clipboard() {}
+  Clipboard() = default;
+  virtual ~Clipboard() = default;
 
   // ObjectType designates the type of data to be stored in the clipboard. This
   // designation is shared across all OSes. The system-specific designation

diff --git a/ui/base/clipboard/clipboard_aura.cc b/ui/base/clipboard/clipboard_aura.cc
@@ -50,7 +50,7 @@ class ClipboardData {
       : web_smart_paste_(false),
         format_(0) {}
 
-  virtual ~ClipboardData() {}
+  virtual ~ClipboardData() = default;
 
   // Bitmask of AuraClipboardFormat types.
   int format() const { return format_; }
@@ -164,7 +164,7 @@ class AuraClipboard {
   AuraClipboard() : sequence_number_(0) {
   }
 
-  ~AuraClipboard() {}
+  ~AuraClipboard() = default;
 
   void Clear() {
     sequence_number_++;

diff --git a/ui/base/clipboard/clipboard_format_type_android.cc b/ui/base/clipboard/clipboard_format_type_android.cc
@@ -22,12 +22,12 @@ const char kBookmarkFormat[] = "bookmark";
 }  // namespace
 
 // ClipboardFormatType implementation.
-ClipboardFormatType::ClipboardFormatType() {}
+ClipboardFormatType::ClipboardFormatType() = default;
 
 ClipboardFormatType::ClipboardFormatType(const std::string& native_format)
     : data_(native_format) {}
 
-ClipboardFormatType::~ClipboardFormatType() {}
+ClipboardFormatType::~ClipboardFormatType() = default;
 
 std::string ClipboardFormatType::Serialize() const {
   return data_;

diff --git a/ui/base/clipboard/clipboard_format_type_win.cc b/ui/base/clipboard/clipboard_format_type_win.cc
@@ -15,7 +15,7 @@
 namespace ui {
 
 // ClipboardFormatType implementation.
-ClipboardFormatType::ClipboardFormatType() {}
+ClipboardFormatType::ClipboardFormatType() = default;
 
 ClipboardFormatType::ClipboardFormatType(UINT native_format) {
   // There's no good way to actually initialize this in the constructor in
@@ -47,7 +47,7 @@ ClipboardFormatType::ClipboardFormatType(UINT native_format,
   data_.tymed = tymed;
 }
 
-ClipboardFormatType::~ClipboardFormatType() {}
+ClipboardFormatType::~ClipboardFormatType() = default;
 
 std::string ClipboardFormatType::Serialize() const {
   return base::NumberToString(data_.cfFormat);

diff --git a/ui/base/clipboard/clipboard_monitor.cc b/ui/base/clipboard/clipboard_monitor.cc
@@ -9,7 +9,7 @@
 
 namespace ui {
 
-ClipboardMonitor::ClipboardMonitor() {}
+ClipboardMonitor::ClipboardMonitor() = default;
 
 ClipboardMonitor::~ClipboardMonitor() {
   DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);

diff --git a/ui/base/clipboard/clipboard_observer.h b/ui/base/clipboard/clipboard_observer.h
@@ -17,7 +17,7 @@ class COMPONENT_EXPORT(BASE_CLIPBOARD) ClipboardObserver {
   virtual void OnClipboardDataChanged() = 0;
 
  protected:
-  virtual ~ClipboardObserver() {}
+  virtual ~ClipboardObserver() = default;
 };
 
 }  // namespace ui

diff --git a/ui/base/clipboard/clipboard_test_template.h b/ui/base/clipboard/clipboard_test_template.h
@@ -59,7 +59,7 @@ namespace ui {
 template <typename ClipboardTraits>
 class ClipboardTest : public PlatformTest {
  public:
-  ClipboardTest() {}
+  ClipboardTest() = default;
   ~ClipboardTest() override = default;
 
   // PlatformTest:

diff --git a/ui/base/clipboard/test/test_clipboard.cc b/ui/base/clipboard/test/test_clipboard.cc
@@ -17,7 +17,7 @@ namespace ui {
 TestClipboard::TestClipboard()
     : default_store_type_(CLIPBOARD_TYPE_COPY_PASTE) {}
 
-TestClipboard::~TestClipboard() {}
+TestClipboard::~TestClipboard() = default;
 
 Clipboard* TestClipboard::CreateForCurrentThread() {
   base::AutoLock lock(Clipboard::clipboard_map_lock_.Get());
@@ -208,7 +208,7 @@ TestClipboard::DataStore::DataStore() : sequence_number(0) {}
 
 TestClipboard::DataStore::DataStore(const DataStore& other) = default;
 
-TestClipboard::DataStore::~DataStore() {}
+TestClipboard::DataStore::~DataStore() = default;
 
 void TestClipboard::DataStore::Clear() {
   data.clear();