Skip to content

Commit

Permalink
net_unittests: Re-enable HTTPSOCSPVerifyTest.VerifyResult on macOS
Browse files Browse the repository at this point in the history
The test got disabled but it was apparently just flaky due to the general
vpython test_server flake on macOS (crbug.com/869227), so re-enable it.

Bug: 949958
Change-Id: Iebd8088eaeda5009f7234a6fbaa039d3b7a7814a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784165
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693329}
  • Loading branch information
matt-mueller authored and Commit Bot committed Sep 4, 2019
1 parent 9a11dad commit eb7067c
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions net/url_request/url_request_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11862,13 +11862,7 @@ class HTTPSOCSPVerifyTest
: public HTTPSOCSPTest,
public testing::WithParamInterface<OCSPVerifyTestData> {};

// TODO(crbug.com/949958): The test is flaky on Mac
#if defined(OS_MACOSX)
#define MAYBE_VerifyResult DISABLED_VerifyResult
#else
#define MAYBE_VerifyResult VerifyResult
#endif
TEST_P(HTTPSOCSPVerifyTest, MAYBE_VerifyResult) {
TEST_P(HTTPSOCSPVerifyTest, VerifyResult) {
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_AUTO);
OCSPVerifyTestData test = GetParam();
Expand Down

0 comments on commit eb7067c

Please sign in to comment.