Skip to content

Commit

Permalink
GWP-ASan: Send fewer metrics
Browse files Browse the repository at this point in the history
Don't send metrics for unrelated crashes, only for GWP-ASan crashes and
error reports. The unrelated crashes are uninteresting and obscure the
other (smaller) numbers of reports that I am interested in.

Bug: 896019
Change-Id: Ic205f5fb0798b489889c2fa639fc2464f066bb6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518755
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641017}
  • Loading branch information
vlad902 authored and Commit Bot committed Mar 15, 2019
1 parent b647cab commit ed504ef
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions components/gwp_asan/crash_handler/crash_handler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ std::unique_ptr<crashpad::MinidumpUserExtensionStreamDataSource>
HandleException(const crashpad::ProcessSnapshot& snapshot) {
gwp_asan::Crash proto;
auto result = CrashAnalyzer::GetExceptionInfo(snapshot, &proto);
UMA_HISTOGRAM_ENUMERATION("GwpAsan.CrashAnalysisResult", result);

if (result != GwpAsanCrashAnalysisResult::kUnrelatedCrash)
UMA_HISTOGRAM_ENUMERATION("GwpAsan.CrashAnalysisResult", result);
if (result != GwpAsanCrashAnalysisResult::kGwpAsanCrash)
return nullptr;

Expand Down

0 comments on commit ed504ef

Please sign in to comment.