[ios/password settings] Drop no-op setter in PasswordFormContentItem

No behavior changed. The value here is never consumed.

Bug: 1392705
Change-Id: I938ec6fa7c0b5b754f073df95c210280360d1bda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4295273
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/main@{#1111891}

ios/chrome/browser/ui/settings/password/password_manager_view_controller.mm

@@ -1117,18 +1117,15 @@ - (PasswordFormContentItem*)savedFormItemForAffiliatedGroup:
   passwordItem.title =
       base::SysUTF8ToNSString(affiliatedGroup.GetDisplayName());
   passwordItem.affiliatedGroup = affiliatedGroup;
-  // TODO(crbug.com/1358978): Temporary credential object so Password Details
-  // works.
-  passwordItem.credential = *affiliatedGroup.GetCredentials().begin();
   const int nbAccounts = affiliatedGroup.GetCredentials().size();
   passwordItem.detailText =
       nbAccounts > 1
           ? l10n_util::GetNSStringF(IDS_IOS_SETTINGS_PASSWORDS_NUMBER_ACCOUNT,
                                     base::NumberToString16(nbAccounts))
           : @"";
   // TODO(crbug.com/1355956): Fix favicon logic.
-  passwordItem.URL =
-      [[CrURL alloc] initWithGURL:GURL(passwordItem.credential.GetURL())];
+  passwordItem.URL = [[CrURL alloc]
+      initWithGURL:affiliatedGroup.GetCredentials().begin()->GetURL()];
   passwordItem.accessibilityTraits |= UIAccessibilityTraitButton;
   passwordItem.accessoryType = UITableViewCellAccessoryDisclosureIndicator;