[Extensions] Remove remnants of networking.castPrivate API

https://chromium-review.googlesource.com/c/chromium/src/+/2818265 removed the majority of the networking.castPrivate extension API (which was previously used by the Chromecast Extension), but missed a couple places (enums and permissions). Clean those up, too. Fixed: 1106093 Change-Id: Iac8818b68ce04c471e4b227ceb6e10a189170679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4301249 Reviewed-by: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1112025}
Denger-Network · Mar 2, 2023 · f5f38ac · f5f38ac
1 parent b51116c
commit f5f38ac
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 14 deletions.
diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc
@@ -168,7 +168,6 @@ constexpr APIPermissionInfo::InitInfo permissions_to_register[] = {
      APIPermissionInfo::kFlagCannotBeOptional},
     {APIPermissionID::kMediaPlayerPrivate, "mediaPlayerPrivate",
      APIPermissionInfo::kFlagCannotBeOptional},
-    {APIPermissionID::kNetworkingCastPrivate, "networking.castPrivate"},
     {APIPermissionID::kPasswordsPrivate, "passwordsPrivate",
      APIPermissionInfo::kFlagCannotBeOptional},
     {APIPermissionID::kPdfViewerPrivate, "pdfViewerPrivate"},

diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc
@@ -848,7 +848,6 @@ TEST(PermissionsTest, PermissionMessages) {
   skip.insert(APIPermissionID::kMediaPlayerPrivate);
   skip.insert(APIPermissionID::kMediaPerceptionPrivate);
   skip.insert(APIPermissionID::kMetricsPrivate);
-  skip.insert(APIPermissionID::kNetworkingCastPrivate);
   skip.insert(APIPermissionID::kPdfViewerPrivate);
   skip.insert(APIPermissionID::kImageWriterPrivate);
   skip.insert(APIPermissionID::kResourcesPrivate);

diff --git a/extensions/browser/extension_function_histogram_value.h b/extensions/browser/extension_function_histogram_value.h
@@ -1222,11 +1222,11 @@ enum HistogramValue {
   AUDIO_SETMUTE = 1161,
   AUDIO_GETDEVICES = 1162,
   VIRTUALKEYBOARD_RESTRICTFEATURES = 1163,
-  NETWORKINGCASTPRIVATE_VERIFYDESTINATION = 1164,
-  NETWORKINGCASTPRIVATE_VERIFYANDENCRYPTCREDENTIALS = 1165,
-  NETWORKINGCASTPRIVATE_VERIFYANDENCRYPTDATA = 1166,
-  NETWORKINGCASTPRIVATE_SETWIFITDLSENABLEDSTATE = 1167,
-  NETWORKINGCASTPRIVATE_GETWIFITDLSSTATUS = 1168,
+  DELETED_NETWORKINGCASTPRIVATE_VERIFYDESTINATION = 1164,
+  DELETED_NETWORKINGCASTPRIVATE_VERIFYANDENCRYPTCREDENTIALS = 1165,
+  DELETED_NETWORKINGCASTPRIVATE_VERIFYANDENCRYPTDATA = 1166,
+  DELETED_NETWORKINGCASTPRIVATE_SETWIFITDLSENABLEDSTATE = 1167,
+  DELETED_NETWORKINGCASTPRIVATE_GETWIFITDLSSTATUS = 1168,
   ACCESSIBILITY_PRIVATE_DARKENSCREEN = 1169,
   // This does not follow the naming convention, but follows the other APIs in
   // webrtcAudioPrivate.

diff --git a/extensions/common/mojom/api_permission_id.mojom b/extensions/common/mojom/api_permission_id.mojom
@@ -227,7 +227,7 @@ enum APIPermissionID {
   kClipboard = 200,
   kNetworkingOnc = 201,
   kVirtualKeyboard = 202,
-  kNetworkingCastPrivate = 203,
+  kDeleted_NetworkingCastPrivate = 203,
   kMediaPerceptionPrivate = 204,
   kLockScreen = 205,
   kNewTabPageOverride = 206,

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -35541,11 +35541,13 @@ Called by update_extension_histograms.py.-->
   <int value="1161" label="AUDIO_SETMUTE"/>
   <int value="1162" label="AUDIO_GETDEVICES"/>
   <int value="1163" label="VIRTUALKEYBOARD_RESTRICTFEATURES"/>
-  <int value="1164" label="NETWORKINGCASTPRIVATE_VERIFYDESTINATION"/>
-  <int value="1165" label="NETWORKINGCASTPRIVATE_VERIFYANDENCRYPTCREDENTIALS"/>
-  <int value="1166" label="NETWORKINGCASTPRIVATE_VERIFYANDENCRYPTDATA"/>
-  <int value="1167" label="NETWORKINGCASTPRIVATE_SETWIFITDLSENABLEDSTATE"/>
-  <int value="1168" label="NETWORKINGCASTPRIVATE_GETWIFITDLSSTATUS"/>
+  <int value="1164" label="DELETED_NETWORKINGCASTPRIVATE_VERIFYDESTINATION"/>
+  <int value="1165"
+      label="DELETED_NETWORKINGCASTPRIVATE_VERIFYANDENCRYPTCREDENTIALS"/>
+  <int value="1166" label="DELETED_NETWORKINGCASTPRIVATE_VERIFYANDENCRYPTDATA"/>
+  <int value="1167"
+      label="DELETED_NETWORKINGCASTPRIVATE_SETWIFITDLSENABLEDSTATE"/>
+  <int value="1168" label="DELETED_NETWORKINGCASTPRIVATE_GETWIFITDLSSTATUS"/>
   <int value="1169" label="ACCESSIBILITY_PRIVATE_DARKENSCREEN"/>
   <int value="1170" label="WEBRTC_AUDIO_PRIVATE_SET_AUDIO_EXPERIMENTS"/>
   <int value="1171" label="AUTOTESTPRIVATE_GETPLAYSTORESTATE"/>
@@ -36767,7 +36769,7 @@ Called by update_extension_permission.py.-->
   <int value="200" label="kClipboard"/>
   <int value="201" label="kNetworkingOnc"/>
   <int value="202" label="kVirtualKeyboard"/>
-  <int value="203" label="kNetworkingCastPrivate"/>
+  <int value="203" label="kDeleted_NetworkingCastPrivate"/>
   <int value="204" label="kMediaPerceptionPrivate"/>
   <int value="205" label="kLockScreen"/>
   <int value="206" label="kNewTabPageOverride"/>