Skip to content

Commit

Permalink
[fuchsia] Enable base_util_unittests on waterfall & CQ.
Browse files Browse the repository at this point in the history
New //base primitives are being added under //base/util, which has its
own unit-tests suite, so we should be running that.

Bug: 1020698
Change-Id: I5126381cf2fc1fdf3a5b6e466cd994d23167f926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062420
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743066}
  • Loading branch information
Wez authored and Commit Bot committed Feb 20, 2020
1 parent 2fef0e9 commit f66f79a
Show file tree
Hide file tree
Showing 4 changed files with 79 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
namespace util {

TEST(MultiSourceMemoryPressureMonitorTest, RunDispatchCallback) {
base::test::TaskEnvironment task_environment;
base::test::SingleThreadTaskEnvironment task_environment(
base::test::TaskEnvironment::MainThreadType::IO);

MultiSourceMemoryPressureMonitor monitor;
monitor.Start();
auto* aggregator = monitor.aggregator_for_testing();
Expand All @@ -35,8 +37,10 @@ TEST(MultiSourceMemoryPressureMonitorTest, RunDispatchCallback) {
}

TEST(MultiSourceMemoryPressureMonitorTest, Histograms) {
base::test::TaskEnvironment task_environment(
base::test::SingleThreadTaskEnvironment task_environment(
base::test::TaskEnvironment::MainThreadType::IO,
base::test::TaskEnvironment::TimeSource::MOCK_TIME);

MultiSourceMemoryPressureMonitor monitor;
base::HistogramTester histogram_tester;
monitor.Start();
Expand Down
52 changes: 52 additions & 0 deletions testing/buildbot/chromium.fyi.json
Original file line number Diff line number Diff line change
Expand Up @@ -11733,6 +11733,24 @@
"test": "base_unittests",
"test_target": "//base:base_unittests"
},
{
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"cpu": "arm64",
"inside_docker": "1",
"os": "Ubuntu-16.04"
}
]
},
"test": "base_util_unittests",
"test_target": "//base/util:base_util_unittests"
},
{
"merge": {
"args": [],
Expand Down Expand Up @@ -12350,6 +12368,23 @@
"test": "base_unittests",
"test_target": "//base:base_unittests"
},
{
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"kvm": "1",
"os": "Ubuntu-16.04"
}
]
},
"test": "base_util_unittests",
"test_target": "//base/util:base_util_unittests"
},
{
"merge": {
"args": [],
Expand Down Expand Up @@ -12936,6 +12971,23 @@
"test": "base_unittests",
"test_target": "//base:base_unittests"
},
{
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"kvm": "1",
"os": "Ubuntu-16.04"
}
]
},
"test": "base_util_unittests",
"test_target": "//base/util:base_util_unittests"
},
{
"merge": {
"args": [],
Expand Down
20 changes: 20 additions & 0 deletions testing/buildbot/chromium.linux.json
Original file line number Diff line number Diff line change
Expand Up @@ -1734,6 +1734,26 @@
"test": "base_unittests",
"test_target": "//base:base_unittests"
},
{
"args": [
"--device=aemu"
],
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_gtest_merge.py"
},
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"kvm": "1",
"os": "Ubuntu-16.04"
}
]
},
"test": "base_util_unittests",
"test_target": "//base/util:base_util_unittests"
},
{
"args": [
"--device=aemu"
Expand Down
1 change: 1 addition & 0 deletions testing/buildbot/test_suites.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -1228,6 +1228,7 @@
'fuchsia_gtests': {
'angle_unittests': {},
'base_unittests': {},
'base_util_unittests': {},
'blink_common_unittests': {},
'blink_heap_unittests': {},
'blink_platform_unittests': {},
Expand Down

0 comments on commit f66f79a

Please sign in to comment.