forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
This change removes the above named base::Features, which are no longer exposed via chrome://flags, and whose removal in M94 has been publicly announced. The associated behaviors, SameSite-Lax-by-default and SameSite=None-requires-Secure, have been standardized and launched in Chromium as well as other browsers. This change modifies CanonicalCookie logic to consider only the CookieAccessSemantics when determining effective SameSite, adjusts tests, and updates some comments. (Schemeful Same-Site, i.e. net::features::kSchemefulSameSite, and other cookie and SameSite-related base::Features are unaffected.) Bug: 1211388 Change-Id: Id3ffca3a34dc64ab076c92506682ddaa5a674602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3059260 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#906943}
- Loading branch information
Showing
15 changed files
with
264 additions
and
655 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.