dark_mode: Remove dark mode icon from settings search

Personalization hub will use personalization icon for all features including dark mode search results in Chrome Settings. (NIT) This CL also add "(Deprecated)" to dark mode settings enums that was removed in the other CL. Bug: 1321965 Test: Manual Change-Id: I02518f3a1669dfad4a437913cdee2f610e5c4b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3620785 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/main@{#998680}
Denger-Network · May 3, 2022 · f997e8a · f997e8a
1 parent 2b828c6
commit f997e8a
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/chrome/browser/resources/settings/chromeos/os_icons.html b/chrome/browser/resources/settings/chromeos/os_icons.html
@@ -69,7 +69,6 @@
 
       <!-- Personalization icon -->
       <g id="paint-brush"><path d="M4.5 11C3 11 2 12 2 13.3c0 1-1 1.6-1.6 1.6.7 1 2 1.5 3.3 1.5 1.7 0 3.2-1.4 3.2-3 0-1.4-1-2.4-2.4-2.4zM12.7 1a2 2 0 0 1 2.8 0L17 2.4c.8.8.8 2 0 2.8l-6.3 6.4a2 2 0 0 1-2.9 0l-1.4-1.4a2 2 0 0 1 0-2.8L12.7 1zM14 2.4L7.7 8.8l1.5 1.4 6.3-6.4-1.4-1.4z"></path></g>
-      <g id="dark-mode"><path fill-rule="evenodd" clip-rule="evenodd" d="M18 10C18 14.4183 14.4183 18 10 18C5.58172 18 2 14.4183 2 10C2 5.58172 5.58172 2 10 2C14.4183 2 18 5.58172 18 10ZM16.1176 9.99997C16.1176 6.62129 13.3787 3.88232 10 3.88232V16.1176C13.3787 16.1176 16.1176 13.3787 16.1176 9.99997Z"></path></g>
 
       <!-- General OS Settings icons -->
       <g id="accessibility"><path fill-rule="evenodd" clip-rule="evenodd" d="M12 3C12 4.10457 11.1046 5 10 5C8.89543 5 8 4.10457 8 3C8 1.89543 8.89543 1 10 1C11.1046 1 12 1.89543 12 3ZM2 7C2 6.44772 2.44772 6 3 6H17C17.5523 6 18 6.44772 18 7C18 7.55228 17.5523 8 17 8H13V13V18C13 18.5523 12.5523 19 12 19C11.4477 19 11 18.5523 11 18V13H9V18C9 18.5523 8.55228 19 8 19C7.44772 19 7 18.5523 7 18V13V8H3C2.44772 8 2 7.55228 2 7Z"></path></g>

diff --git a/chrome/browser/resources/settings/chromeos/os_settings_search_box/os_search_result_row.js b/chrome/browser/resources/settings/chromeos/os_settings_search_box/os_search_result_row.js
@@ -637,8 +637,6 @@ function longestCommonSubstrings(string1, string2) {
           return 'os-settings:chrome';
         case Icon.kClock:
           return 'os-settings:access-time';
-        case Icon.kDarkMode:
-          return 'os-settings:dark-mode';
         case Icon.kDeveloperTags:
           return 'os-settings:developer-tags';
         case Icon.kDisplay:

diff --git a/chrome/browser/ui/webui/settings/chromeos/search/search_result_icon.mojom b/chrome/browser/ui/webui/settings/chromeos/search/search_result_icon.mojom
@@ -16,7 +16,6 @@ enum SearchResultIcon {
   kCellular,
   kChrome,
   kClock,
-  kDarkMode,
   kDeveloperTags,
   kDisplay,
   kDrive,

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -69248,8 +69248,8 @@ Called by update_net_trust_anchors.py.-->
   <int value="502" label="Ambient Mode Source"/>
   <int value="503" label="Change Device Account Image"/>
   <int value="504" label="Ambient Mode Update Photos Containers (Deprecated)"/>
-  <int value="505" label="Dark Mode: On/Off"/>
-  <int value="506" label="Dark Mode: Accent Color"/>
+  <int value="505" label="Dark Mode: On/Off (Deprecated)"/>
+  <int value="506" label="Dark Mode: Accent Color (Deprecated)"/>
   <int value="600" label="Preferred Search Engine"/>
   <int value="601" label="Assistant: On/Off"/>
   <int value="602" label="Assistant: Related Info"/>