Skip to content

Commit

Permalink
Update builder name w3c-test-autoroller -> wpt-importer (src repo)
Browse files Browse the repository at this point in the history
Bug: 706499

Change-Id: Ia649d35f81089eee35f5fb8aab88cd55502a2a6e
Reviewed-on: https://chromium-review.googlesource.com/462339
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#460785}
  • Loading branch information
qyearsley authored and Commit Bot committed Mar 30, 2017
1 parent a77dde6 commit fab627a
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 16 deletions.
23 changes: 10 additions & 13 deletions docs/testing/web_platform_tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@ mission of improving the web. We believe that leveraging and contributing to a
shared test suite is one of the most important tools in achieving
interoperability between browsers. The [web-platform-tests
repository](https://github.com/w3c/web-platform-tests) is the primary shared
test suite where all browser engines are collaborating. There's also a
[csswg-test repository](https://github.com/w3c/csswg-test) for CSS tests, but
that will [soon be merged into
web-platform-tests](https://github.com/w3c/csswg-test/issues/1102).
test suite where all browser engines are collaborating.

Chromium has a 2-way import/export process with the upstream web-platform-tests
repository, where tests are imported into
Expand All @@ -23,9 +20,9 @@ web-platform-tests, including tips for writing and reviewing tests.

## Importing tests

Chromium has mirrors
([web-platform-tests](https://chromium.googlesource.com/external/w3c/web-platform-tests/),
[csswg-test](https://chromium.googlesource.com/external/w3c/csswg-test/)) of the
Chromium has a mirror
([web-platform-tests](https://chromium.googlesource.com/external/w3c/web-platform-tests/)
of the
GitHub repos, and periodically imports a subset of the tests so that they are
run as part of the regular Blink layout test testing process.

Expand All @@ -37,13 +34,13 @@ possible, and running as many of the tests as possible.
### Automatic import process

There is an automatic process for updating the Chromium copy of
web-platform-tests. The import is done by the builder [w3c-test-autoroller
builder](https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller).
web-platform-tests. The import is done by the builder [wpt-importer
builder](https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer).

The easiest way to check the status of recent imports is to look at:

- Recent logs on Buildbot for [w3c-test-autoroller
builder](https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller)
- Recent logs on Buildbot for [wpt-importer
builder](https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer)
- Recent CLs created by
[blink-w3c-test-autoroller@chromium.org](https://codereview.chromium.org/search?owner=blink-w3c-test-autoroller%40chromium.org).

Expand Down Expand Up @@ -75,8 +72,8 @@ which has a list of directories to skip while importing.
In addition to the directories and tests explicitly skipped there, tests may
also be skipped for a couple other reasons, e.g. if the file path is too long
for Windows. To check what files are skipped in import, check the recent logs
for [w3c-test-autoroller
builder](https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller).
for [wpt-importer
builder](https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer).

### Manual import

Expand Down
2 changes: 1 addition & 1 deletion third_party/WebKit/LayoutTests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -1881,7 +1881,7 @@ crbug.com/695270 [ Linux ] external/csswg-test/css-writing-modes-3/overconstrain

crbug.com/626703 external/wpt/domxpath/001.html [ Failure ]

# ====== New tests from w3c-test-autoroller added here ======
# ====== New tests from wpt-importer added here ======
crbug.com/626703 external/wpt/html/browsers/windows/browsing-context-names/browsing-context-choose-parent-004.html [ Timeout ]
crbug.com/626703 external/csswg-test/css-cascade-4/revert-val-001.html [ Failure ]
crbug.com/626703 external/csswg-test/css-ui-3/box-sizing-026.html [ Failure ]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

"""Updates layout test expectations and baselines when updating w3c tests.
"""Updates expectations and baselines when updating web-platform-tests.
Specifically, this class fetches results from try bots for the current CL, then
(1) downloads new baseline files for any tests that can be rebaselined, and
Expand All @@ -21,7 +21,7 @@

_log = logging.getLogger(__name__)

MARKER_COMMENT = '# ====== New tests from w3c-test-autoroller added here ======'
MARKER_COMMENT = '# ====== New tests from wpt-importer added here ======'


class WPTExpectationsUpdater(object):
Expand Down

0 comments on commit fab627a

Please sign in to comment.