Skip to content

Commit

Permalink
Remove stale gn arg to avoid undeclared argument warning.
Browse files Browse the repository at this point in the history
v8_enable_inspector was removed recently. Clean up remnants.

Also fixes a dependent gn check issue which blocked submission,
http://crrev.com/462467 did not update GN deps for new header.

BUG=645890,708965
TEST=none

Review-Url: https://codereview.chromium.org/2801123002
Cr-Commit-Position: refs/heads/master@{#462652}
  • Loading branch information
dalecurtis authored and Commit bot committed Apr 6, 2017
1 parent 93dc650 commit fd6c741
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion .gn
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ default_args = {
"//third_party/WebKit/Source/core/streams/WritableStream.js",
]
v8_experimental_extra_library_files = []
v8_enable_inspector = true
v8_enable_gdbjit = false
v8_imminent_deprecation_warnings = false
}
Expand Down
1 change: 1 addition & 0 deletions content/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -1651,6 +1651,7 @@ test("content_unittests") {
"//third_party/opus",
"//third_party/webrtc/api:libjingle_peerconnection",
"//third_party/webrtc/api:rtc_stats_api",
"//third_party/webrtc/api/video_codecs:video_codecs_api",
"//third_party/webrtc/base:rtc_base",
"//third_party/webrtc/media:rtc_media",
"//third_party/webrtc/modules/desktop_capture:primitives",
Expand Down
2 changes: 0 additions & 2 deletions ios/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,13 @@ declare_args() {
# the overrides are never used.
v8_extra_library_files = []
v8_experimental_extra_library_files = []
v8_enable_inspector = true
v8_enable_gdbjit = false
v8_imminent_deprecation_warnings = false
}

# Prevent warnings for unused build args above.
assert(v8_extra_library_files != 0)
assert(v8_experimental_extra_library_files != 0)
assert(v8_enable_inspector)
assert(!v8_enable_gdbjit)
assert(!v8_imminent_deprecation_warnings)

Expand Down

0 comments on commit fd6c741

Please sign in to comment.