Skip to content

Commit

Permalink
[Windows] Remove NOTREACHED from IsReparsePoint.
Browse files Browse the repository at this point in the history
This CL removes the NOTREACHED check from the function as it doesn't
provide any value and just causes unexpected crashes in the browser
process during debug builds.

Bug: 1029073
Change-Id: I14de816b9fd4415238fa4244316baa4c06fcdc15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992167
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729609}
  • Loading branch information
James Forshaw authored and Commit Bot committed Jan 9, 2020
1 parent 369c5f5 commit fec18f6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion sandbox/win/src/win_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ DWORD IsReparsePoint(const std::wstring& full_path) {
(path.rfind(L'\\') == kNTDotPrefixLen - 1)) {
break;
}
NOTREACHED_NT();
return error;
}
} else if (FILE_ATTRIBUTE_REPARSE_POINT & attributes) {
Expand Down

0 comments on commit fec18f6

Please sign in to comment.