Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s14 sources #267

Merged
merged 1 commit into from
May 18, 2021
Merged

s14 sources #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
s14 sources
  • Loading branch information
@delphiactual
delphiactual committed May 17, 2021
commit 4a351df94e1e538b5a4c7e74b84d967fae6ca634
24 changes: 22 additions & 2 deletions data/sources/categories.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,18 @@
"includes": ["Garden of Salvation"],
"items": ["Divinity"]
},
"gunsmith": { "includes": ["Banshee-44", "Salvager's Salvo Armament Quest"], "excludes": ["Vanguard", "Crucible", "Gambit"] },
"gunsmith": {
"includes": [
"Banshee-44",
"Salvager's Salvo Armament Quest",
"Source: A Sacred Fusion Quest"
],
"excludes": [
"Vanguard",
"Crucible",
"Gambit"
]
},
"ikora": { "includes": ["ikora"] },
"io": { "includes": ["on io", "The Pyramidion"] },
"ironbanner": {
Expand Down Expand Up @@ -450,6 +461,11 @@
"crownofsorrow"
]
},
"servitor": {
"includes": [
"Source: Season of the Splicer"
]
},
"ignore": {
"includes": [
"Forging Your Own Path",
Expand All @@ -460,7 +476,11 @@
"Season of the Worthy",
"Season of the Hunt",
"Artifacts - IGNORE",
"Ornaments - IGNORE"
"Ornaments - IGNORE",
"Source: Acquired from Ada-1",
"Source: Splicer Servitor",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand why ignoring Ada-1 and Splicer Servitor. are we specifically aiming for only sources that support the Inventory page?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was my intent here as these are just mods

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool looks good

"Source: Seasonal Artifact",
"Source: Season of the Chosen"
]
}
},
Expand Down
12 changes: 1 addition & 11 deletions data/sources/unassigned.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1 @@
{
"1546689276": "Source: Acquired from Ada-1",
"1600754038": "Source: Season of the Splicer Activities",
"1828592460": "Source: Splicer Servitor",
"1935530529": "Source: Seasonal Artifact",
"1995616326": "Source: Season of the Chosen",
"2040801502": "Source: Season of the Splicer Triumph",
"2694738712": "Source: Season of the Splicer Quest",
"2967385539": "Source: Season of the Splicer Seasonal Challenges",
"3512613235": "Source: A Sacred Fusion Quest"
}
{}
1 change: 1 addition & 0 deletions output/missing-source-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2629,6 +2629,7 @@ const missingSources: { [key: string]: number[] } = {
4078925541, // Substitutional Alloy Mask
4078925542, // Substitutional Alloy Mask
],
servitor: [],
shatteredthrone: [],
shaxx: [
85800627, // Ankaa Seeker IV
Expand Down
12 changes: 12 additions & 0 deletions output/source-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,7 @@ const D2Sources: {
sourceHashes: [
1788267693, // Source: Earn rank-up packages from Banshee-44.
2986841134, // Source: Salvager's Salvo Armament Quest
3512613235, // Source: A Sacred Fusion Quest
],
searchString: [],
},
Expand Down Expand Up @@ -904,6 +905,17 @@ const D2Sources: {
],
searchString: [],
},
servitor: {
itemHashes: [],
sourceHashes: [
277706045, // Source: Season of the Splicer Nightfall Grandmaster
1600754038, // Source: Season of the Splicer Activities
2040801502, // Source: Season of the Splicer Triumph
2694738712, // Source: Season of the Splicer Quest
2967385539, // Source: Season of the Splicer Seasonal Challenges
],
searchString: [],
},
shatteredthrone: {
itemHashes: [
185321778, // The Eternal Return
Expand Down