Look up Resonant Element objectives by name instead of assuming their hash matches the plug #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the objective hash will match the plug hash.
nev-r
approved these changes
Mar 9, 2022
delphiactual
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue whereby Deepsight weapons with raid perks do not show that Drowned Elements can be extracted from them. Once DIM picks this change up, the
deepsight:drownedsearch filter will become available.I was previously assuming that the hashes of Resonant Element plugs (which show up in the Deepsight Resonance socket on weapons) would match the corresponding objective hashes (which show up on weapon perks). This is true for most Resonant Elements, but isn't the case for Drowned Elements which are used for raid-exclusive perks.