Generate d2-season-info.ts && better watermark detection #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delphiactual
commented
Jun 27, 2022
delphiactual
changed the title
|
This will require writing a new |
delphiactual
force-pushed
the
generate-d2-season-info
branch
from
db6a3af
to
560e119
Compare
identify watermarks via seasonpass rewards fix typo in override dropped this sort watermark-to-season.json semi-stable fixup shaders ftw fix erroneously marked season 15 items updates updates remove "" from keys generate-data D2CalculatedSeason by un-redactedness user powerCaps where available fixup . comments and better var naming remove useless conditionals ... generate-watermark-info cleanup add comments, update variable names - generate-season-info generate event watermarks based off of event shaders remove stray debug comment modularize
delphiactual
force-pushed
the
generate-d2-season-info
branch
from
560e119
to
32d02df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #360
To-Do:
This should make less human interaction necessary for both d2-season-info and watermark detection.
D2CalculatedSeason is now based upon the largest season number without
[Redacted]in the name, instead of how close to a season start it is... This should prevent erroneous seasons being applied to items completely.seasonal watermarks are completely generated from the manifest without the need for having a secondary source of truth... This was accomplished by checking against the season pass reward items, then against shaders, and finally against armor if any watermarks remain in the list of all watermarks.
event watermarks are still generated by using a manually curated list of shaders.event watermarks are now generated from shaders for events using the stack uniquelabel which contains event descriptors.