Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source ritual / pinnacle #436

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Source ritual / pinnacle #436

merged 3 commits into from
Jan 17, 2023

Conversation

delphiactual
Copy link
Collaborator

@delphiactual delphiactual commented Jan 12, 2023

open to better names but this does work in autocomplete

source:weapon:ritual
source:weapon:pinnacle

@robojumper
Copy link
Member

Not sure if I like the colon in the query value -- it doesn't seem to cause immediate issues for DIM's query parsing/validation logic, but it seems slightly misleading since all other filter terms with a "middle hand side" use some form of comparator on the RHS (like basestat:resilience:>=20.

@delphiactual
Copy link
Collaborator Author

delphiactual commented Jan 12, 2023

true, but my thought here was the ability to add for example source:dungeon and source:dungeon:spire same for raid et al

@lowPolySkeleton
Copy link
Member

Source:weapon seems odd since weapon isn’t a source where source:dungeon is. Not sure how I would specify a middling term for these. I like the dungeon idea could extend to raid as well. But for these it’s probably better with no middle

@delphiactual
Copy link
Collaborator Author

source:pinnacle-weapons
source:ritual-weapons
?

@delphiactual delphiactual merged commit 900370a into master Jan 17, 2023
@delphiactual delphiactual deleted the source-ritual branch January 17, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants