-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new intrinsic perk lookup table #76
Conversation
This is not entirely correct...
should be
and
should be
and
should be
|
added a strict mode to the intrinsic perk lookup, if This only occurs on:
|
fde743f
to
cd0be1b
Compare
Should put |
], | ||
"6": [ | ||
[-99999999, 1791592647, 2770223582], | ||
[-7777777, 1458010786, 2189829540, 1322370662, 4045839491, 2144092201, 1863355414], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1322370662 should not be here
[-7777777, 4172267910], | ||
[-7777777, 4172267910, 3642491337, 4072668471], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[-7777777, 4172267910]
should be removed as it is contained in the next line completely
This will eventually replace
intrinsic-perk-lookup.json
withintrinsic-perk-lookup-v2.json
which will be in the format of:intrinsic-perk-lookup2.txt
contains information gleaned from mercules massive breakdown, it can be deleted before the PR is merged.I have got the object containing all the data outputting to
intrinsic-perk-lookupV2.json
, it still needs to be massaged into the above format, but I have hit a roadblock in how to access this data efficiently...Based on feedback from:
https://www.reddit.com/r/DestinyItemManager/comments/ds7dqw/comparing_archetypes_is_broken_for_some_weapons/ this should be the way forward...
Exotic (isExotic:
true
) intrinsic perks should be matched based offimpact
if no impact matches, then it is not compatible, if animpact
match occurs on two different intrinsics then a tie-breaker should occur based on rate of fire. The same should occur for intrinsic perks that are not real frames (isExotic:false
, isFrame:false
)