Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC updates: unify the specialisation documents into the root doc #2

Merged
merged 6 commits into from
May 18, 2022
Merged

RFC updates: unify the specialisation documents into the root doc #2

merged 6 commits into from
May 18, 2022

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented May 17, 2022 •
edited
Loading

Description

Implementing this update: NixOS/rfcs#125 (comment)

Checklist
  • Built with cargo build
  • Formatted with cargo fmt
  • Linted with cargo clippy
  • Ran tests with cargo test
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)

@grahamc
Embed specialisation's bootspec document into the root bootspec doc
483624a
@grahamc
synthesis test output: rename to a unified document format
d164570 
Now that the RFC says specialisations use a single document
to express all of the specialisations instead of referring
to other files, flatten the structure by renaming all the
files into a single file in a single directory.

Note the only diff here is embedding the
21.11-specialisations/example document into the 21.11-specialisations
document.
@grahamc
fixup
ac7a98f
@grahamc
integration test case: update to generate single .json documents
2cda8f9
@grahamc
Fixup clippy lint
220e78c
@grahamc grahamc requested a review from firestack May 17, 2022 19:55
@grahamc grahamc mentioned this pull request May 17, 2022
Merged
@firestack

This comment was marked as resolved.

Sign in to view
firestack
firestack approved these changes May 18, 2022
View reviewed changes
synthesize/src/lib.rs Outdated Show resolved Hide resolved
@firestack
Copy link
Contributor

firestack commented May 18, 2022 •
edited
Loading

Looks great! I like how the error handling was restructured out of synthesize_schema_from_generation

I really couldn't find anything to change that was in the diffs, and therefore github didn't let me comment on them heh.

@grahamc grahamc merged commit d2ae15a into main May 18, 2022
@grahamc grahamc deleted the rfc-embed-subs branch May 18, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamc @firestack