This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Bittrex exchange #1269
Merged
Bittrex exchange #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backfill utilizing candle API for long term, normal market history for last 100 trades (bittrex limitation) Centralize error handling Gracefully handle URL error Handle error when API doesn’t return data (bittrex glitch) Logging of err and data objects for debug purposes. (to be converted to verbose option in later check-in)
Most API errors trapped Backfill using Candle and market API. Made calls to api more synchronous to eliminate race conditions causing cloud flare to throw up errors (Invalid URL) Update products.json generation. remove debug code converted foreach calls to for in to allow for synchronous calculation and eliminate extra code to simulate synchronous calls. Centralize error handling and retry calls.
Remove comments
Implement a minimum call time. get market data can now be called only in 15 second intervals. This blocks rapid fire calls from new backfill command which caused cloud flare errors due to excessive calls in a small period of time.
Selector added as a field to work around a bug in backfill. Once bug in backfill is corrected this fix will be redundant, as it will be overwritten by backfill function removed moment and converted to date object. changed all trade_ID or trade.time (ticks) for more consistency, and id is always numeric. Added presorting of output data to make sure trades received from 2 places are sort into correct order.
DeviaVir
approved these changes
Feb 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bittrex backfill using candle info for longer than 100 history trades
Centralize Error handling
Traps more API errors
Rework calls to make them more synchronous (helps with reducing physical api calls)
Code simplification to allow for central error handling.
I’ve been running this version for 2 days and have not received any errors, but I can’t replicated all conditions, so I am sure there are conditions I have not accounted for.