Add Pydantic models #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some tests too
Add configurations for black and flake8, switch to format to plain string, change non-membership test add missing comma, and reformat code
Use parametrize, and update to use content keyword to avoid warnings
VictoriaBeilsten-Edmands
force-pushed
the
add-pydantic-models
branch
from
58798e5
to
0c38c79
Compare
|
Need to remove |
PeterC-DLS
reviewed
Nov 3, 2022
PeterC-DLS
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Pydantic BaseModels, change IntEnums to Enums and use generic types in type hints