Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plot_id #18

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Remove plot_id #18

merged 3 commits into from
Nov 7, 2022

Conversation

VictoriaBeilsten-Edmands
Copy link
Collaborator

Remove plot_ids from data messages
Add DataMessage base class
Use types for enums in Typescript

PeterC-DLS
PeterC-DLS reviewed Nov 4, 2022
View reviewed changes
api/main.py Outdated Show resolved Hide resolved
api/plot/custom_types.py Outdated Show resolved Hide resolved
PeterC-DLS
PeterC-DLS approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands merged commit ea3b315 into main Nov 7, 2022
@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands deleted the remove-plot-id-2 branch November 7, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterC-DLS PeterC-DLS PeterC-DLS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictoriaBeilsten-Edmands @PeterC-DLS