Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle parameters with empty lists as values #31

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

GDYendell
Copy link
Contributor

@GDYendell GDYendell commented Aug 20, 2024

Fixes #30

>>> dbgrep("*Error*")
...
ODIN-118:EF:0StatusError
ODIN-118:FP:FP0:Error
ODIN-118:FP:FP1:Error
ODIN-118:FP:FP2:Error
ODIN-118:FP:FP3:Error
ODIN-118:MW:0StatusError

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (c213f25) to head (7467e1e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files          10       10           
  Lines         360      360           
=======================================
  Hits          293      293           
  Misses         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it wasn't immediately clear to me how _walk_odin_metadata was meant to work so added some extra tests until I understood the edge cases. Hope that's ok

@GDYendell GDYendell merged commit 17f44ea into main Aug 20, 2024
19 checks passed
@GDYendell GDYendell deleted the empty-list-parameters branch August 20, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

During introspection empty list values are ignored
2 participants