Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

added other OS to the matrix #88

Merged
merged 8 commits into from
Aug 2, 2023
Merged

added other OS to the matrix #88

merged 8 commits into from
Aug 2, 2023

Conversation

evalott100
Copy link
Collaborator

Closes #81

@codecov
Copy link

codecov bot commented May 23, 2023 •
edited
Loading

Codecov Report

Merging #88 (78d1e2a) into main (5c8c98f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 78d1e2a differs from pull request most recent head 6ba0798. Consider uploading reports for the commit 6ba0798 to get more accurate results

@@            Coverage Diff            @@
##              main       #88   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          223       223           
=========================================
  Hits           223       223
Impacted Files Coverage Δ
src/python3_pip_skeleton/__main__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@evalott100 evalott100 force-pushed the add_windows_and_mac_to_matrix branch 5 times, most recently from 6e2840f to 9a78e80 Compare May 24, 2023 07:50
@evalott100 evalott100 force-pushed the add_windows_and_mac_to_matrix branch 16 times, most recently from 15ddf5b to daf4b5b Compare May 24, 2023 12:34
@evalott100
Copy link
Collaborator Author

evalott100 commented May 24, 2023 •
edited
Loading

I have to skip the pip upgrade step in test_new_module for the windows machine (the runner doesn't have permissions to change pip3.exe)... Since this is an addition I made fix local problems at diamond on linux machines I'd say it doesn't matter too much.

@evalott100 evalott100 force-pushed the add_windows_and_mac_to_matrix branch from daf4b5b to ccf914e Compare May 24, 2023 13:29
coretl
coretl suggested changes Jun 20, 2023
View reviewed changes
src/python3_pip_skeleton/__main__.py Outdated Show resolved Hide resolved
tests/test_adopt.py Outdated Show resolved Hide resolved
.github/actions/install_requirements/action.yml Outdated Show resolved Hide resolved
.github/pages/make_switcher.py Outdated Show resolved Hide resolved
tests/test_boilerplate_removed.py Outdated Show resolved Hide resolved
@evalott100 evalott100 force-pushed the add_windows_and_mac_to_matrix branch from 1e31679 to fe2361a Compare June 20, 2023 10:17
@evalott100 evalott100 force-pushed the add_windows_and_mac_to_matrix branch from 855f0f3 to 93c75e7 Compare June 20, 2023 10:19
@evalott100 evalott100 mentioned this pull request Jun 20, 2023
Merged
@evalott100
Copy link
Collaborator Author

@coretl The changes to actions are in DiamondLightSource/python3-pip-skeleton#143, cherry-picked here.

@coretl coretl merged commit 2e0ad72 into main Aug 2, 2023
23 checks passed
@coretl coretl deleted the add_windows_and_mac_to_matrix branch August 2, 2023 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coretl coretl coretl approved these changes

@gilesknap gilesknap Awaiting requested review from gilesknap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add windows and mac to matrix in python3-pip-skeleton-cli
2 participants
@evalott100 @coretl