Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Stop checking switcher in docs build #106

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Stop checking switcher in docs build #106

merged 1 commit into from
Jan 6, 2023

Conversation

callumforrester
Copy link
Contributor

We don't want to check switcher because there are 3 possible states for a repo:

  1. New project, docs are not published so there is no switcher
  2. Existing project with latest skeleton, switcher should be there
  3. Existing project with skeleton being either adopted or updated, switcher may or mar not be there and its state is unknown.

Point 3 makes checking switcher difficult, because if it is not as the theme expects, it needs to be manually fixed on every branch.
This PR sets check_switcher to False and adds a comment explaining why.

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #106 (3bc1660) into main (e2e7d86) will not change coverage.
The diff coverage is n/a.

❗ Current head 3bc1660 differs from pull request most recent head e7fcc7d. Consider uploading reports for the commit e7fcc7d to get more accurate results

@@            Coverage Diff            @@
##              main      #106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           13        13           
=========================================
  Hits            13        13           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

docs/conf.py Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
@coretl
Copy link
Contributor

coretl commented Jan 5, 2023

Please can you squash and push and I'll merge

@coretl coretl merged commit 8eb1194 into main Jan 6, 2023
@coretl coretl deleted the dont-check-switcher branch January 6, 2023 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants