Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for COMMAND INFO command #148

Closed
arpitbbhayani opened this issue Jul 12, 2024 · 16 comments
Closed

Add support for COMMAND INFO command #148

arpitbbhayani opened this issue Jul 12, 2024 · 16 comments

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the COMMAND INFO command in DiceDB similar to the COMMAND INFO command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@shashankdaima
Copy link

I have created a shallow PR as WIP. #151

@maniSHarma7575
Copy link

maniSHarma7575 commented Jul 26, 2024

@shashankdaima Are you still working on this? I don't see any activity on this from couple of weeks

If not, @arpitbbhayani , @JyotinderSingh Could you please assign this to me?

@JyotinderSingh
Copy link
Collaborator

@shashankdaima Are you still working on this? I don't see any activity on this from couple of weeks

If not, @arpitbbhayani , @JyotinderSingh Could you please assign this to me?

Assigned to you.

@sanimesh96
Copy link

Hi @maniSHarma7575, Are you still working on this? I dont see any activity on this issue so far.
If not, i would like to take up this issue. Can you assign this to me?
cc: @JyotinderSingh,@arpitbbhayani.

@JyotinderSingh
Copy link
Collaborator

Hi @maniSHarma7575, Are you still working on this? I dont see any activity on this issue so far.

If not, i would like to take up this issue. Can you assign this to me?

cc: @JyotinderSingh,@arpitbbhayani.

Assigned

@AshwinKul28
Copy link
Contributor

@sanimesh96 Any latest updates on this? Please pull the latest from the master in the PR and move it from Draft to Review.

@AshwinKul28
Copy link
Contributor

#326 (comment)

@arpitbbhayani
Copy link
Contributor Author

@sanimesh96 any updates on this? we would like to close this as soon as possible. Do you need any help?

@JyotinderSingh
Copy link
Collaborator

This issue is available to be taken up.

@psrvere
Copy link
Contributor

psrvere commented Sep 18, 2024

@JyotinderSingh - Please assign to me

@meetghodasara
Copy link
Contributor

@JyotinderSingh I would also like to work on this issue. Please assign it to me. Thanks.

@gauravrp
Copy link

@JyotinderSingh Can this issue be assigned to me?

@JyotinderSingh
Copy link
Collaborator

@JyotinderSingh - Please assign to me

Assigned to @gauravrp for now to allow more people to get involved into contributing.

@JyotinderSingh
Copy link
Collaborator

@JyotinderSingh I would also like to work on this issue. Please assign it to me. Thanks.

Assigned to @gauravrp for now to allow more people to get involved into contributing.

@gauravrp
Copy link

gauravrp commented Oct 2, 2024

@meetghodasara If the PR for this issue has been merged, can we please close it?

@lucifercr07
Copy link
Contributor

Closing, merged as part of #612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants