Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command HINCRBY #647

Closed
arpitbbhayani opened this issue Sep 20, 2024 · 6 comments · Fixed by #701
Closed

Add support for command HINCRBY #647

arpitbbhayani opened this issue Sep 20, 2024 · 6 comments · Fixed by #701

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the HINCRBY command in DiceDB similar to the HINCRBY command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@hash-f
Copy link
Contributor

hash-f commented Sep 20, 2024

@arpitbbhayani, I would like to take this on. Please assign this to me.

@arpitbbhayani
Copy link
Contributor Author

@hash-f you already have another one on your plate :) will keep this one open for someone else to take up.

@hash-f
Copy link
Contributor

hash-f commented Sep 20, 2024

Sure, sure. One is enough. Thank you! Someone else commented on that other issue before me. So I thought that one was going to him. :P

@ankkyprasad
Copy link
Contributor

Hi @arpitbbhayani, I'd like to work on this issue. Can you please assign this to me?

@meetghodasara
Copy link
Contributor

Hi @arpitbbhayani , I am excited to work on this issue. Can you please assigned it to me?

@AshwinKul28
Copy link
Contributor

Hey @ankkyprasad go for it.

@meetghodasara can you please check other opened issues. Thanks for showing interest! 🥳

This was referenced Sep 23, 2024
JyotinderSingh added a commit that referenced this issue Sep 26, 2024
Co-authored-by: Jyotinder Singh <jyotindrsingh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants