Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command HKEYS #649

Closed
arpitbbhayani opened this issue Sep 20, 2024 · 6 comments · Fixed by #886
Closed

Add support for command HKEYS #649

arpitbbhayani opened this issue Sep 20, 2024 · 6 comments · Fixed by #886

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the HKEYS command in DiceDB similar to the HKEYS command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@ayushsatyam146
Copy link
Contributor

ayushsatyam146 commented Sep 20, 2024

Can I take this issue? @arpitbbhayani @JyotinderSingh

@swarajrb7
Copy link
Contributor

@arpitbbhayani Can I pick this issue?

@lucifercr07
Copy link
Contributor

@swarajrb7 assigned, thanks for contributing.

@RishabhC-137
Copy link

Can I work on this issue? @arpitbbhayani

@swarajrb7
Copy link
Contributor

swarajrb7 commented Sep 25, 2024

Have completed the working of the command. Currently working on writing integration_test.

@swarajrb7
Copy link
Contributor

Update: Will create the PR in couple days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants