Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#855: Make DiceDB build work on different architectures #856

Merged

Conversation

swaingotnochill
Copy link
Contributor

Fixes #855

This fix uses environment environment variables to get the different architecture and Operating system and avoids the usage of default linux build.

Additionally,

  1. Added help command to see the make options available.
  2. Added clean command to clean the build artifcats.

Makefile Outdated Show resolved Hide resolved
   This fix uses environment environment variables to get the different architecture and Operating system and avoids the usage of default linux build

chore: reverting back to original version
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucifercr07 lucifercr07 changed the title fix: make build works on different architecture #855: Make DiceDB build work on different architectures Sep 30, 2024
@lucifercr07 lucifercr07 merged commit 87f5d83 into DiceDB:master Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile: Running default make commands fails in different architecture
3 participants