Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#874: adding unit tests for hash map implementation and helper functions #880

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

ayushsatyam146
Copy link
Contributor

Closes #874

Adding unit tests for internal/eval/hashmap implementation along with the helper functions.

@lucifercr07
Copy link
Contributor

lucifercr07 commented Sep 30, 2024

@ayushsatyam146 build is failing, please fix.

@ayushsatyam146
Copy link
Contributor Author

@lucifercr07 build tests passing now

@ayushsatyam146
Copy link
Contributor Author

@JyotinderSingh @AshwinKul28 can you guys review this please, Thanks!

Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these test cases. LGTM.

@JyotinderSingh JyotinderSingh changed the title add: adding unit tests for hash map implementation and helper functions #874: add: adding unit tests for hash map implementation and helper functions Oct 1, 2024
@JyotinderSingh JyotinderSingh changed the title #874: add: adding unit tests for hash map implementation and helper functions #874: adding unit tests for hash map implementation and helper functions Oct 1, 2024
@JyotinderSingh JyotinderSingh merged commit 678cfca into DiceDB:master Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No tests available for eval/hmap
3 participants