Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and make documentation for command JSON.CLEAR consistent #772 #887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nm123github
Copy link

@nm123github nm123github commented Oct 1, 2024

Summary of Changes

Audit documentation for JSON.CLEAR and make it consistent with the existing implementation.
#772

Changes Made

  • Attempted to follow documentation format in SET
  • Found some discrepancies in ## Behaviour section which i changed.
  • Fixed few things in the ## Errors section.

Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nm123github , Most of the changes look good. However, would it be possible to modify example section of this document with bash code block as per below:

Examples: List all possible examples of the command and the expected output. Assume CLI implementation
the CLI prompt should be 127.0.0.1:7379> and not anything else

For reference, please check out the https://dicedb.io/commands/jsonget/#example-usage example section. Note that the overall documentation of json.get is yet to be revamped but the format of the examples is standardized. Additionally for other sections you can refer to the SET command docs.

Thanks.

Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments.

@@ -5,114 +5,91 @@ description: Documentation for the DiceDB command JSON.CLEAR

The `JSON.CLEAR` command is part of the DiceDBJSON module, which allows you to manipulate JSON data stored in DiceDB. This command is used to clear the value at a specified path in a JSON document, effectively setting it to an empty state. This can be particularly useful when you want to reset a part of your JSON document without removing the key itself.
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, as per recent discussion on DiceDb community, DiceDB supports JSON natively hence its not a part of DiceDBJSON module. Would it be okay to update the description accordingly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @apoorvyadav1111, changed to remove part of the DiceDBJSON module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants