[clang-tidy] NO.33 enable bugprone-inaccurate-erase (PaddlePaddle#61589

)
Difers · Feb 20, 2024 · c64f655 · c64f655
1 parent cf6e7b3
commit c64f655
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -11,7 +11,7 @@ bugprone-copy-constructor-init,
 bugprone-exception-escape,
 -bugprone-fold-init-type,
 -bugprone-forwarding-reference-overload,
--bugprone-inaccurate-erase,
+bugprone-inaccurate-erase,
 bugprone-incorrect-roundings,
 -bugprone-infinite-loop,
 bugprone-integer-division,

diff --git a/paddle/phi/kernels/funcs/jit/test.cc b/paddle/phi/kernels/funcs/jit/test.cc
@@ -234,7 +234,8 @@ void TestKernelLSTM() {
   VLOG(10) << "Test JITKernel: " << jit::to_string(KernelTuple::kernel_type);
   std::vector<std::string> all_acts = {"sigmoid", "tanh", "relu", "identity"};
   auto test_sizes = TestSizes();
-  test_sizes.erase(std::remove(test_sizes.begin(), test_sizes.end(), 1000));
+  test_sizes.erase(std::remove(test_sizes.begin(), test_sizes.end(), 1000),
+                   test_sizes.end());
   for (int d : test_sizes) {
     for (bool use_peephole : {true, false}) {
       for (auto& act_gate : all_acts) {
@@ -331,7 +332,8 @@ void TestKernelGRU() {
   VLOG(10) << "Test JITKernel: " << jit::to_string(KernelTuple::kernel_type);
   std::vector<std::string> all_acts = {"sigmoid", "tanh", "relu", "identity"};
   auto test_sizes = TestSizes();
-  test_sizes.erase(std::remove(test_sizes.begin(), test_sizes.end(), 1000));
+  test_sizes.erase(std::remove(test_sizes.begin(), test_sizes.end(), 1000),
+                   test_sizes.end());
   for (int d : test_sizes) {
     for (auto& act_gate : all_acts) {
       for (auto& act_cand : all_acts) {
@@ -491,7 +493,8 @@ void TestKernelCRFDecoding() {
   VLOG(10) << "Test JITKernel: " << jit::to_string(KernelTuple::kernel_type);
   constexpr int state_trans_base_idx = 2;
   auto test_sizes = TestSizes();
-  test_sizes.erase(std::remove(test_sizes.begin(), test_sizes.end(), 2000));
+  test_sizes.erase(std::remove(test_sizes.begin(), test_sizes.end(), 2000),
+                   test_sizes.end());
   for (int seq_len : {1, 11, 17, 50}) {
     for (int tag_num : test_sizes) {
       auto ref = jit::GetReferFunc<KernelTuple>();
@@ -550,7 +553,8 @@ void TestKernelSeqPool() {
   std::vector<jit::SeqPoolType> pool_types = {
       jit::SeqPoolType::kSum, jit::SeqPoolType::kAvg, jit::SeqPoolType::kSqrt};
   auto test_sizes = TestSizes();
-  test_sizes.erase(std::remove(test_sizes.begin(), test_sizes.end(), 1000));
+  test_sizes.erase(std::remove(test_sizes.begin(), test_sizes.end(), 1000),
+                   test_sizes.end());
   for (auto type : pool_types) {
     for (int w : test_sizes) {
       jit::seq_pool_attr_t attr(w, type);
@@ -592,7 +596,8 @@ void TestKernelEmbSeqPool() {
   std::vector<jit::SeqPoolType> pool_types = {
       jit::SeqPoolType::kSum};  // only support sum yet
   auto test_sizes = TestSizes();
-  test_sizes.erase(std::remove(test_sizes.begin(), test_sizes.end(), 1000));
+  test_sizes.erase(std::remove(test_sizes.begin(), test_sizes.end(), 1000),
+                   test_sizes.end());
   for (int tbl_w : test_sizes) {
     std::vector<T> table(tbl_h * tbl_w);
     RandomVec<T>(tbl_h * tbl_w, table.data());