Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Version #18

Closed
flywire opened this issue Dec 3, 2019 · 5 comments
Closed

Display Version #18

flywire opened this issue Dec 3, 2019 · 5 comments

Comments

@flywire
Copy link
Contributor

flywire commented Dec 3, 2019

Version should be displayed in user interface

@flywire
Copy link
Contributor Author

flywire commented Dec 3, 2019

Trying to add an i button but I can't display a form and all the toolbox controls are dimmed out ☹️

@Dijji
Copy link
Owner

Dijji commented Dec 3, 2019

You are right, if the version is to be displayed, it should be on a pop-up window launched by a button on the main screen. However, I can't say I see displaying a version as a particularly important requirement. Why do you think it is needed?

Going down the route of adding it for yourself is a good idea, even if it is tricky at first. And if you succeed, feel free to contribute your source back to the project for incorporation, ideally using a pull request.

Dijji

@flywire
Copy link
Contributor Author

flywire commented Dec 5, 2019

Version displayed on filename Properties, Details, Product Version

@flywire
Copy link
Contributor Author

flywire commented Dec 9, 2019

Version number is a bit hard to pick up.

        private void Button_Click(object sender, RoutedEventArgs e)
        {
            string msg = "View Microsoft Outlook Mail files" + Environment.NewLine;
            msg = msg + Environment.NewLine;
            string Repository = "https://github.com/Dijji/XstReader";
            msg = msg + "Repository: " + Repository + Environment.NewLine;
            msg = msg + "Version: ";
            //Version version = new Version(Application.ProductVersion);
            //MessageBox.Show(msg + version.ToString(), "About XstReader");
            MessageBox.Show(msg, "About XstReader");
                        
        }

@Dijji
Copy link
Owner

Dijji commented Dec 9, 2019

What button is triggering this? I've tried very hard to avoid screen clutter.

This works, but if I were doing this, I would probably do it as a pop-up panel, to give me proper control over layout, and maybe allow for extensions in the information shown, or adding settings (maybe, for instance, to display print headers)

@flywire flywire mentioned this issue Dec 9, 2019
@Dijji Dijji closed this as completed in 3a59208 Dec 11, 2019
just1fi3d pushed a commit to just1fi3d/XstReader that referenced this issue Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants