-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't specify explicit version for dev-dependencies #258
Conversation
alice@pop-os:~/Documents/Code/taffy$ cargo publish --dry-run Updating crates.io index Packaging taffy v0.2.0 (/home/alice/Documents/Code/taffy) error: failed to prepare local package for uploading Caused by: failed to select a version for the requirement `taffy = "^0.2.0"` candidate versions found which didn't match: 0.1.0 location searched: crates.io index required by package `taffy v0.2.0 (/home/alice/Documents/Code/taffy)`
@TimJentzsch, this was added in #165. Unfortunately, it doesn't seem compatible with actually publishing the crate, so I need to revert it. |
My guess is it worked before because 0.1 was already published when I added it. I think I fixed the version because of cargo-deny, hopefully we can make it work somehow.
I see you have good taste in operating systems :D |
I think we can just add taffy to the skip list here in [bans]
multiple-versions = "deny"
wildcards = "deny"
highlight = "all"
# Certain crates/versions that will be skipped when doing duplicate detection.
skip = [
{ name = "itoa", version = "1.0.2" }
] https://embarkstudios.github.io/cargo-deny/checks/bans/cfg.html |
Looks like this is working successfully locally :) This should be disabling the check only for |
Once this PR is merged, I intend to release taffy 0.2.
Testing the release currently fails:
Removing the explicit version causes this to pass correctly. It's currently unclear how this worked before. EDIT: it never has :(