Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specify explicit version for dev-dependencies #258

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

alice-i-cecile
Copy link
Collaborator

@alice-i-cecile alice-i-cecile commented Nov 24, 2022

Once this PR is merged, I intend to release taffy 0.2.

Testing the release currently fails:

alice@pop-os:~/Documents/Code/taffy$ cargo publish --dry-run
Updating crates.io index
Packaging taffy v0.2.0 (/home/alice/Documents/Code/taffy)
error: failed to prepare local package for uploading

Caused by:
failed to select a version for the requirement taffy = "^0.2.0"
candidate versions found which didn't match: 0.1.0
location searched: crates.io index
required by package taffy v0.2.0 (/home/alice/Documents/Code/taffy)

Removing the explicit version causes this to pass correctly. It's currently unclear how this worked before. EDIT: it never has :(

alice@pop-os:~/Documents/Code/taffy$ cargo publish --dry-run
    Updating crates.io index
   Packaging taffy v0.2.0 (/home/alice/Documents/Code/taffy)
error: failed to prepare local package for uploading

Caused by:
  failed to select a version for the requirement `taffy = "^0.2.0"`
  candidate versions found which didn't match: 0.1.0
  location searched: crates.io index
  required by package `taffy v0.2.0 (/home/alice/Documents/Code/taffy)`
@alice-i-cecile alice-i-cecile added the release Preparing for the next version label Nov 24, 2022
@alice-i-cecile
Copy link
Collaborator Author

@TimJentzsch, this was added in #165. Unfortunately, it doesn't seem compatible with actually publishing the crate, so I need to revert it.

@TimJentzsch
Copy link
Collaborator

My guess is it worked before because 0.1 was already published when I added it.

I think I fixed the version because of cargo-deny, hopefully we can make it work somehow.

alice@pop-os

I see you have good taste in operating systems :D

@nicoburns
Copy link
Collaborator

nicoburns commented Nov 24, 2022

I think we can just add taffy to the skip list here in deny.toml:

[bans]
multiple-versions = "deny"
wildcards = "deny"
highlight = "all"
# Certain crates/versions that will be skipped when doing duplicate detection.
skip = [
    { name = "itoa", version = "1.0.2" }
]

https://embarkstudios.github.io/cargo-deny/checks/bans/cfg.html

@alice-i-cecile
Copy link
Collaborator Author

Looks like this is working successfully locally :) This should be disabling the check only for taffy itself. Per the docs, we would need to use skip-tree to disable checks for all descendants.

@alice-i-cecile alice-i-cecile enabled auto-merge (squash) November 24, 2022 14:29
@alice-i-cecile alice-i-cecile merged commit 664ce98 into main Nov 24, 2022
@alice-i-cecile alice-i-cecile deleted the 0.2-release-prep branch November 24, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Preparing for the next version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants