Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v0.4.3 release #646

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

nicoburns
Copy link
Collaborator

@nicoburns nicoburns added the release Preparing for the next version label Apr 12, 2024
@tgross35
Copy link

tgross35 commented Apr 12, 2024

Just FYI we fixed the last item already at ToT, it should work again on the new nightly in about 6ish hours. That being said, I guess it's not the worst thing to try to avoid this pattern in case something winds up changing here in the future.

@nicoburns
Copy link
Collaborator Author

@tgross35 What is "ToT"?

it should work again on the new nightly in about 6ish hours. That being said, I guess it's not the worst thing to try to avoid this pattern in case something winds up changing here in the future.

Excellent, I figured this might get fixed on the rustc side. This particular change (typing the float literal) seems to have no downside, so I figured we might as well merge it.

There is a larger issue for Taffy's API exposed by the rustc issue though, which is that 3rd-party (non-Taffy) callers of the API may still be broken, which would be particularly if those callers were also libraries. That's a little trickier to fix as I think it would require changing the function parameter from impl Into<f32> + Copy to either f32 or impl Into<f64> + Copy which would semver-breaking. I'm not currently planning to fix that issue on the Taffy side.

@nicoburns nicoburns merged commit 066949d into DioxusLabs:main Apr 12, 2024
23 checks passed
@nicoburns nicoburns deleted the release/0.4.3 branch April 12, 2024 23:01
@tgross35
Copy link

@tgross35 What is "ToT"?

Top of tree, think I picked that up from somebody's test suite that tries every commit.

I agree that this is a quite tricky thing to dance around and really don't know what is best either. Thanks for being on top of this, having the little fixes in the ecosystem early is great in case the compiler does change some behavior 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Preparing for the next version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants