Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak a few strings that refer to Python #1805

Closed
wants to merge 3 commits into from
Closed

Tweak a few strings that refer to Python #1805

wants to merge 3 commits into from

Conversation

luabud
Copy link
Contributor

@luabud luabud commented Mar 23, 2023

heejaechang and others added 3 commits March 22, 2023 10:57
@heejaechang
Share telemetry from core extension. (#20893)
01e798a 
it turns out the new telemetry API removed a way to set extension id and
version when telemetry reporter is created and it implicitly sets from
extension reporter is created. the same way how LSP client is working.

since we want to keep using the same extension id and etc for our
telemetry, we need the reporter created from core ext.
@karthiknadig
Fix title and placeholder for python selection when using create env …
61f93c3 
…command (#20896)

Closes #19891


![image](https://user-images.githubusercontent.com/3840081/227031948-de595993-80e1-43a0-8dd8-658848c6b3d5.png)
@luabud
Adjust a few strings that mention Python
35abb0b
@luabud luabud closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luabud @heejaechang @karthiknadig