Attempt to support garbage collected arrays/vectors #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crashes even the most basic tests :( Everything is broken. I feel like I need to cleanup.
Techcable
added
the
impl-simple
This was referenced Jul 4, 2021
Using the small-object-arenas allocator still causes a SEGFAULT unfortunately. However, I've made significant progress ;)
As of now, the 'array' tests pass. Add cfg!(zerogc_simple_debug_alloc) which adds internal padding bytes. This was very helpful in finding this bug ;)
They should suppress the generation of implicit where bounds
They are unsafe, because GcVec has an explicit reference to the owning context, which cant be meaningfully erased. Add GcVec::extend_from_slice
Mostly a copy of the "arrays" test. It's even in the same file.
Dangling pointers don't have a valid `GcVecHeader`, so its not possible to fetch the length/capacity. The allocated vector is a singleton (assuming proper alignment), so we still wont waste much memory.
Also remove the Drop impl from GcRawVec. Dropping is the responsibility of the underlying RawVecRepr.
We were including the header in the 'value_layout', which should only be the array value....
If we want to keep using it, we need the garbage collector to preserve it.... Fix GcVec::extend_from_slice to correctly do set_len
|
You are right @andersk . I'll put that next on my TODO list :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crashes even the most basic tests :(
Everything is broken.
I feel like I need to clean up the allocator interface even more.
NOTE: This supersedes #20