Merge pull request #802 from DuendeSoftware/brock/device-flow

update session id and description for user interaction in device flow
DuendeSoftware · Mar 18, 2022 · bd1778d · bd1778d
2 parents b22c7ea + ed2d462
commit bd1778d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/clients/src/ConsoleDeviceFlow/Program.cs b/clients/src/ConsoleDeviceFlow/Program.cs
@@ -1,4 +1,4 @@
-using Clients;
+using Clients;
 using IdentityModel;
 using IdentityModel.Client;
 using System;
@@ -35,7 +35,8 @@ static async Task<DeviceAuthorizationResponse> RequestAuthorizationAsync()
             var response = await client.RequestDeviceAuthorizationAsync(new DeviceAuthorizationRequest
             {
                 Address = disco.DeviceAuthorizationEndpoint,
-                ClientId = "device"
+                ClientId = "device",
+                ClientCredentialStyle = ClientCredentialStyle.PostBody
             });
 
             if (response.IsError) throw new Exception(response.Error);

diff --git a/src/EntityFramework.Storage/Stores/DeviceFlowStore.cs b/src/EntityFramework.Storage/Stores/DeviceFlowStore.cs
@@ -140,6 +140,8 @@ public virtual async Task UpdateByUserCodeAsync(string userCode, DeviceCode data
 
         existing.SubjectId = data.Subject?.FindFirst(JwtClaimTypes.Subject).Value;
         existing.Data = entity.Data;
+        existing.SessionId = data.SessionId;
+        existing.Description = data.Description;
 
         try
         {
@@ -194,6 +196,8 @@ public virtual async Task RemoveByDeviceCodeAsync(string deviceCode)
     /// <returns></returns>
     protected DeviceFlowCodes ToEntity(DeviceCode model, string deviceCode, string userCode)
     {
+        // TODO: consider removing this in v7.0 since it's not properly/fully used
+
         if (model == null || deviceCode == null || userCode == null) return null;
 
         return new DeviceFlowCodes
@@ -202,6 +206,8 @@ protected DeviceFlowCodes ToEntity(DeviceCode model, string deviceCode, string u
             UserCode = userCode,
             ClientId = model.ClientId,
             SubjectId = model.Subject?.FindFirst(JwtClaimTypes.Subject).Value,
+            SessionId = model.SessionId,
+            Description = model.Description,
             CreationTime = model.CreationTime,
             Expiration = model.CreationTime.AddSeconds(model.Lifetime),
             Data = Serializer.Serialize(model)