Fix refresh token data fixup upgrade when using DefaultPersistedGrantService #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh tokens had a format change in v5, and the code to migrate and fixup old records was in the DefaultRefreshTokenStore. But some code, namely the DefaultPersistedGrantService, skips the store and deserializes the payload directly. This was skipping the fixup logic, so this PR moves this fixup logic down into the PersistentGrantSerializer so that both code paths will get the correct behavior.
Fix for: DuendeSoftware/Support#214