Always emit the sid claim in id tokens #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, we only needed the sid claim in the check session endpoint, and only included the sid claim when that endpoint was enabled check session. Now we have more cases where the sid claim is useful, so we are no longer going to make the sid claim conditional on the EnableCheckSessionEndpoint option
josephdecock
commented
Feb 2, 2023
| } | ||
| else | ||
| { | ||
| request.SessionId = ""; // empty string for anonymous users | ||
| LogError("SessionId is missing", request); |
There was a problem hiding this comment.
I don't think it is normally possible to not have a session id, so I think logging this as an error and then continuing is reasonable.
brockallen
approved these changes
Feb 2, 2023
brockallen
added a commit
that referenced
this pull request
Feb 2, 2023
Always emit the sid claim in id tokens
brockallen
added a commit
that referenced
this pull request
Feb 2, 2023
Merge pull request #1157 from DuendeSoftware/joe/always-emit-sid-claim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, we only needed the sid claim in the check session endpoint, and only included the sid claim when that endpoint was enabled. Now we have more cases where the sid claim is useful, so we are no longer going to make the sid claim conditional on the EnableCheckSessionEndpoint option