PAR - support processed params in authorize endpoint #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is "on top of" #1565 because max age=0 has the same issue as prompt=login. We should merge 1565 first. |
|
This is an alternative to #1563, and I think we should do this one because 1563 would have been a breaking change even for unaffected users. The approach was also pretty questionable/hacky. |
josephdecock
force-pushed
the
joe/par-prompt-query-params
branch
from
7e5eef3
to
ef48531
Compare
josephdecock
force-pushed
the
joe/par-prompt-query-params
branch
from
ef48531
to
6176445
Compare
josephdecock
force-pushed
the
joe/par-prompt-query-params
branch
from
6176445
to
89736be
Compare
brockallen
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1562, which is a bug where the prompt (or max_age=0) parameter could not be used with PAR because we weren't respecting the processed flag.