Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SupportedPromptModes customization #1582

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Allow SupportedPromptModes customization #1582

merged 2 commits into from
Sep 20, 2024

Conversation

josephdecock
Copy link
Member

Closes #1530

@brockallen
Copy link
Member

Let's add a unit/integration test that shows a custom value is passed all the way to the login page.

@josephdecock
Copy link
Member Author

Test should exercise authorize endpoint, proving that we don't fail with custom prompt

@josephdecock
Copy link
Member Author

@brockallen this is ready for you now.

@josephdecock josephdecock merged commit d9afcc3 into releases/7.0.x Sep 20, 2024
3 checks passed
@brockallen brockallen deleted the joe/expose-supported-prompt-modes branch September 20, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brockallen brockallen brockallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephdecock @brockallen