Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create JTI on each new access token #53

Merged
merged 1 commit into from
Dec 19, 2020
Merged

Create JTI on each new access token #53

merged 1 commit into from
Dec 19, 2020

Conversation

brockallen
Copy link
Member

@brockallen brockallen commented Dec 18, 2020 •
edited
Loading

Persisted/Cached access tokens stored in the refresh token persisted grant kept JTI as claim in DB, and new access tokens were not generating new JTI each renewal.

  • add property to Token to indicate need for jti
  • move jti creation to CreateSecurityTokenAsync and out of CreateAccessTokenAsync
  • handle older tokens that do not have new property

@brockallen
add property to include jti, move jto creation to CreateSecurityToken…
6fdecd1 
…Async, and handle older tokens that do not have new property
@brockallen brockallen added the bug Something isn't working label Dec 18, 2020
@brockallen brockallen added this to the 5.0.0 milestone Dec 18, 2020
@leastprivilege leastprivilege merged commit d682065 into main Dec 19, 2020
@leastprivilege leastprivilege deleted the brock/fix_jwt_id_regeneration branch December 19, 2020 09:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leastprivilege leastprivilege leastprivilege approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@brockallen @leastprivilege